Issue 285413003: Mojo: Remove dangerous default argument in mojom_bindings_generatory.py: ProcessFile().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 285413003: Mojo: Remove dangerous default argument in mojom_bindings_generatory.py: ProcessFile(). (Closed)

Created:
6 years, 7 months ago by viettrungluu

Modified:
6 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Remove dangerous default argument in mojom_bindings_generatory.py: ProcessFile(). (The other dangerous default argument, _processed_files, is as intended, since it's meant to memoize across all invocations. _imported_filename_stack was unnecessarily dangerous, but there was no bug since we never modified it.) R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270771

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	mojo/public/tools/bindings/mojom_bindings_generator.py	View		1 chunk	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

6 years, 7 months ago (2014-05-15 19:21:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r270771 (presubmit successful).

Expand Messages | Collapse Messages