Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2306)

Unified Diff: courgette/patcher_x86_32.h

Issue 2854113002: [Courgette] Reduce AssemblyProgram to reduce Courgette-apply RAM floor and disk churn. (Closed)
Patch Set: Update courgette_fuzzer in libfuzzer. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « courgette/patch_generator_x86_32.h ('k') | courgette/program_detector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: courgette/patcher_x86_32.h
diff --git a/courgette/patcher_x86_32.h b/courgette/patcher_x86_32.h
index fa822dc48ae1042d64be3183e37a5330afa961f7..3524437c7bf25ce1c6fd5279aba6503e475133b4 100644
--- a/courgette/patcher_x86_32.h
+++ b/courgette/patcher_x86_32.h
@@ -7,14 +7,12 @@
#include <stdint.h>
-#include <memory>
-
+#include "base/logging.h"
#include "base/macros.h"
-#include "courgette/assembly_program.h"
#include "courgette/courgette_flow.h"
-#include "courgette/encoded_program.h"
#include "courgette/ensemble.h"
-#include "courgette/program_detector.h"
+#include "courgette/region.h"
+#include "courgette/streams.h"
namespace courgette {
@@ -49,12 +47,17 @@ class PatcherX86_32 : public TransformationPatcher {
Status Transform(SourceStreamSet* corrected_parameters,
SinkStreamSet* transformed_element) {
+ if (!corrected_parameters->Empty())
+ return C_GENERAL_ERROR; // Don't expect any corrected parameters.
+
CourgetteFlow flow;
RegionBuffer only_buffer(
Region(ensemble_region_.start() + base_offset_, base_length_));
- flow.ReadAssemblyProgramFromBuffer(flow.ONLY, only_buffer, false);
- flow.CreateEncodedProgramFromAssemblyProgram(flow.ONLY);
+ flow.ReadDisassemblerFromBuffer(flow.ONLY, only_buffer);
+ flow.CreateAssemblyProgramFromDisassembler(flow.ONLY, false);
+ flow.CreateEncodedProgramFromDisassemblerAndAssemblyProgram(flow.ONLY);
flow.DestroyAssemblyProgram(flow.ONLY);
+ flow.DestroyDisassembler(flow.ONLY);
flow.WriteSinkStreamSetFromEncodedProgram(flow.ONLY, transformed_element);
if (flow.failed())
LOG(ERROR) << flow.message();
« no previous file with comments | « courgette/patch_generator_x86_32.h ('k') | courgette/program_detector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698