Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: courgette/encode_decode_unittest.cc

Issue 2854113002: [Courgette] Reduce AssemblyProgram to reduce Courgette-apply RAM floor and disk churn. (Closed)
Patch Set: Update courgette_fuzzer in libfuzzer. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « courgette/disassembler_elf_32_x86_unittest.cc ('k') | courgette/encoded_program.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: courgette/encode_decode_unittest.cc
diff --git a/courgette/encode_decode_unittest.cc b/courgette/encode_decode_unittest.cc
index 7b705f12fd4555299ae0397fcd485f7648e35fea..a07baf398c4e54f21d1dd0e5ff6a064bba0f1553 100644
--- a/courgette/encode_decode_unittest.cc
+++ b/courgette/encode_decode_unittest.cc
@@ -6,12 +6,9 @@
#include <memory>
-#include "courgette/assembly_program.h"
#include "courgette/base_test_unittest.h"
#include "courgette/courgette.h"
#include "courgette/courgette_flow.h"
-#include "courgette/encoded_program.h"
-#include "courgette/program_detector.h"
#include "courgette/streams.h"
namespace courgette {
@@ -31,11 +28,15 @@ void EncodeDecodeTest::TestAssembleToStreamDisassemble(
// Convert executable to encoded assembly.
RegionBuffer original_buffer(Region(original_data, original_length));
- flow.ReadAssemblyProgramFromBuffer(flow.ONLY, original_buffer, false);
+ flow.ReadDisassemblerFromBuffer(flow.ONLY, original_buffer);
+ EXPECT_EQ(C_OK, flow.status());
+ EXPECT_TRUE(nullptr != flow.data(flow.ONLY)->disassembler.get());
+
+ flow.CreateAssemblyProgramFromDisassembler(flow.ONLY, false);
EXPECT_EQ(C_OK, flow.status());
EXPECT_TRUE(nullptr != flow.data(flow.ONLY)->program.get());
- flow.CreateEncodedProgramFromAssemblyProgram(flow.ONLY);
+ flow.CreateEncodedProgramFromDisassemblerAndAssemblyProgram(flow.ONLY);
EXPECT_EQ(C_OK, flow.status());
EXPECT_TRUE(nullptr != flow.data(flow.ONLY)->encoded.get());
@@ -43,6 +44,10 @@ void EncodeDecodeTest::TestAssembleToStreamDisassemble(
EXPECT_EQ(C_OK, flow.status());
EXPECT_TRUE(nullptr == flow.data(flow.ONLY)->program.get());
+ flow.DestroyDisassembler(flow.ONLY);
+ EXPECT_EQ(C_OK, flow.status());
+ EXPECT_TRUE(nullptr == flow.data(flow.ONLY)->disassembler.get());
+
flow.WriteSinkStreamSetFromEncodedProgram(flow.ONLY);
EXPECT_EQ(C_OK, flow.status());
« no previous file with comments | « courgette/disassembler_elf_32_x86_unittest.cc ('k') | courgette/encoded_program.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698