Chromium Code Reviews
Help | Chromium Project | Sign in
(4)

Issue 2854053: Disk cache: Stop evictions while performing final cleanup.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by rvargas (out of office)
Modified:
3 years, 11 months ago
Reviewers:
gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Disk cache: Stop evictions while performing final cleanup. The evictions code may post tasks for further processing and that is a problem at cache destruction, so add an explicit method to stop evictions. BUG=49547 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52964

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M net/disk_cache/backend_impl.h View 1 chunk +1 line, -0 lines 1 comment Download
M net/disk_cache/backend_impl.cc View 2 chunks +10 lines, -1 line 0 comments Download
M net/disk_cache/eviction.h View 2 chunks +5 lines, -1 line 0 comments Download
M net/disk_cache/eviction.cc View 1 chunk +11 lines, -0 lines 2 comments Download
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
rvargas (out of office)
4 years, 10 months ago (2010-07-19 21:04:11 UTC) #1
gavinp
LGTM, with a question about eviction.cc ? http://codereview.chromium.org/2854053/diff/1/3 File net/disk_cache/backend_impl.h (right): http://codereview.chromium.org/2854053/diff/1/3#newcode87 net/disk_cache/backend_impl.h:87: void StartCleanup(); ...
4 years, 10 months ago (2010-07-19 22:20:31 UTC) #2
rvargas (out of office)
4 years, 10 months ago (2010-07-19 23:48:26 UTC) #3
thanks

http://codereview.chromium.org/2854053/diff/1/4
File net/disk_cache/eviction.cc (right):

http://codereview.chromium.org/2854053/diff/1/4#newcode78
net/disk_cache/eviction.cc:78: return;
On 2010/07/19 22:20:31, gavinp wrote:
> NOTREACHED() ?
> 

I added a comment explaining when we'll reach Stop without a call to Init.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be