Disk cache: Stop evictions while performing final cleanup....

Disk cache: Stop evictions while performing final cleanup.

The evictions code may post tasks for further processing and
that is a problem at cache destruction, so add an explicit
method to stop evictions.

BUG=49547
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52964

[gavinp, 2010-07-19 22:20:31]

LGTM, with a question about eviction.cc ?

http://codereview.chromium.org/2854053/diff/1/3
File net/disk_cache/backend_impl.h (right):

http://codereview.chromium.org/2854053/diff/1/3#newcode87
net/disk_cache/backend_impl.h:87: void StartCleanup();
Can we document the distinction between StartCleanup() and CleanupCache() here? 
They're really similar.

http://codereview.chromium.org/2854053/diff/1/4
File net/disk_cache/eviction.cc (right):

http://codereview.chromium.org/2854053/diff/1/4#newcode78
net/disk_cache/eviction.cc:78: return;
NOTREACHED() ?

[rvargas (doing something else), 2010-07-19 23:48:26]

thanks

http://codereview.chromium.org/2854053/diff/1/4
File net/disk_cache/eviction.cc (right):

http://codereview.chromium.org/2854053/diff/1/4#newcode78
net/disk_cache/eviction.cc:78: return;
On 2010/07/19 22:20:31, gavinp wrote:
> NOTREACHED() ?
> 

I added a comment explaining when we'll reach Stop without a call to Init.