Issue 2854041: Fix a bug effectively disabling the default plugin.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2854041: Fix a bug effectively disabling the default plugin. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 11 months ago by Bernhard Bauer

Modified:
4 years ago

Reviewers:
Nico

CC:
chromium-reviews, jam, ben+cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Fix a bug effectively disabling the default plugin. Also, re-enable DefaultPluginUITest.DefaultPluginLoadTest. BUG=48388, 46662 TEST=DefaultPluginUITest.DefaultPluginLoadTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51713

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add braces. #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	chrome/browser/default_plugin_uitest.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	webkit/glue/plugins/plugin_list.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Trybot results:

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

Add 46662 to the BUG= line. The windows trybot failures might be real; not sure.

4 years, 10 months ago (2010-07-06 23:56:05 UTC) #2

Nico

4 years, 10 months ago (2010-07-06 23:58:26 UTC) #3

http://codereview.chromium.org/2854041/diff/1/3
File webkit/glue/plugins/plugin_list.cc (right):

http://codereview.chromium.org/2854041/diff/1/3#newcode385
webkit/glue/plugins/plugin_list.cc:385: FindDisabledPlugin(mime_type,
allow_wildcard, info))
(nit: if either expression or body of an if are more than one line long, the if
requires braces)

Expand Messages | Collapse Messages