Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 285403003: Re-land: Store and restore view focus in OnWindowFocused. (Closed)

Created:
6 years, 7 months ago by msw
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Visibility:
Public.

Description

Re-land: Store and restore view focus in OnWindowFocused. r271281 reverted the first r271249 for Win XP test failures: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/31239/steps/interactive_ui_tests/logs/stdio [ RUN ] ConstrainedWindowViewTest.ClosesOnEscape [216:3316:0517/130516:ERROR:gpu_info_collector_win.cc(103)] Can't retrieve a valid WinSAT assessment. c:\b\build\slave\cr-win-rel\build\src\chrome\browser\ui\views\constrained_window_views_browsertest.cc(206): error: Value of: dialog->GetWidget() Actual: 08C1F9C0 Expected: 0 Which is: NULL This CL makes that test no-op on XP; I'll follow up in Issue 177482. ------------------------------------------------------------ Mimic [Desktop]NativeWidgetAura::OnWindowActivated. Simplify OnNativeBlur calls and OnNative[Blur|Focus] impls. (View focus changes update the TextInputClient as needed) Rewrite and enable related ConstrainedWindowViewTests. Print GetLastError() in SendInput() error case for tests. (key presses get 5/ERROR_ACCESS_DENIED on locked desktops?) BUG=368691, 170331, 177482, 163931 TEST=Automated tests; the focused Views change as expected between the browser, web contents, and web content modal dialogs (print preview, collected cookies, etc.). TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271312

Patch Set 1 #

Patch Set 2 : Disable ConstrainedWindowViewTest.ClosesOnEscape on Win XP. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -410 lines) Patch
M chrome/browser/ui/views/constrained_window_views_browsertest.cc View 1 2 chunks +139 lines, -394 lines 0 comments Download
M ui/base/win/foreground_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 2 chunks +13 lines, -4 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
msw
The CQ bit was checked by msw@chromium.org
6 years, 7 months ago (2014-05-18 16:33:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/285403003/20001
6 years, 7 months ago (2014-05-18 16:33:41 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-18 19:42:32 UTC) #3
Message was sent while issue was closed.
Change committed as 271312

Powered by Google App Engine
This is Rietveld 408576698