Push API: define push event on Service Worker.

Source/modules/push_messaging/PushEvent.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef PushEvent_h
+#define PushEvent_h
+
+#include "core/events/Event.h"
+

[Peter Beverloo, 2014/05/16 15:41:43]

IWYU please

[Michael van Ouwerkerk, 2014/05/21 17:06:42]

Done.

+namespace WebCore {
+
+struct PushEventInit : public EventInit {
+    PushEventInit();
+
+    String data;
+};
+
+class PushEvent FINAL : public Event {
+public:
+    static PassRefPtr<PushEvent> create()

[Peter Beverloo, 2014/05/16 15:41:43]

PassRefPtrWillBeRawPtr (elsewhere too)

[Michael van Ouwerkerk, 2014/05/21 17:06:42]

Done.

+    {
+        return adoptRef(new PushEvent);

[Peter Beverloo, 2014/05/16 15:41:43]

adoptRefWillBeNoop (elsewhere too)

[Michael van Ouwerkerk, 2014/05/21 17:06:42]

Done.

+    }
+    static PassRefPtr<PushEvent> create(const AtomicString& type, const String& data)
+    {
+        return adoptRef(new PushEvent(type, data));
+    }
+    static PassRefPtr<PushEvent> create(const AtomicString& type, const PushEventInit& initializer)
+    {
+        return adoptRef(new PushEvent(type, initializer));
+    }
+
+    virtual ~PushEvent();
+
+    virtual const AtomicString& interfaceName() const OVERRIDE;
+
+    String data() const { return m_data; }
+

[Peter Beverloo, 2014/05/16 15:41:43]

Hmm. Most other Event implementations override the virtual trace() method, only
to call the method in the class which defines it. That's pointless, and there's
no traceable members of this class, so fine to keep it out.

[Michael van Ouwerkerk, 2014/05/21 17:06:42]

Ok.

+private:
+    PushEvent();
+    PushEvent(const AtomicString& type, const String& data);
+    PushEvent(const AtomicString&, const PushEventInit&);

[Peter Beverloo, 2014/05/16 15:41:43]

Please name the first argument (since AtomicString is not clear on itself).

[Michael van Ouwerkerk, 2014/05/21 17:06:42]

Done.

+    String m_data;
+};
+
+} // namespace WebCore
+
+#endif // PushEvent_h