Source/modules/push_messaging/PushEvent.idl - Issue 285403002: Push API: define push event on Service Worker.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/push_messaging/PushEvent.idl

Issue 285403002: Push API: define push event on Service Worker. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add webexposed. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [	5 [

	6 EventConstructor,

6 RuntimeEnabled=PushMessaging,	7 RuntimeEnabled=PushMessaging,

7 ] partial interface Navigator {	8 ] interface PushEvent : Event {
	Peter Beverloo 2014/06/06 09:47:47 The spec defines this as PushMessage. Are you deli The spec defines this as PushMessage. Are you deliberately deriving from that name? Michael van Ouwerkerk 2014/06/06 09:59:48 The spec seems to define no name for the event int Show quoted text On 2014/06/06 09:47:47, Peter Beverloo wrote: > The spec defines this as PushMessage. Are you deliberately deriving from that > name? The spec seems to define no name for the event interface. Maybe we should add a WebIDL snippet to the spec like for GamepadEvent: http://www.w3.org/TR/2014/WD-gamepad-20140225/#gamepadevent-interface
8 readonly attribute PushManager push;	9 [InitializedByEventConstructor] readonly attribute DOMString data;

9 };	10 };

OLD	NEW