Chromium Code Reviews
Help | Chromium Project | Sign in
(30)

Issue 2854007: Asynchronously generate key pairs for <keygen> tag (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 8 months ago by David Benjamin
Modified:
3 years, 8 months ago
Reviewers:
wtc
CC:
chromium-reviews, jam+cc_chromium.org, cbentzel+watch_chromium.org, ben+cc_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, PaweĊ‚ Hajdan Jr.
Visibility:
Public.

Description

Asynchronously generate key pairs for <keygen> tag We currently hang up the IO thread. R=wtc BUG=148 TEST=verify that downloads, etc., are not interrupted by a <keygen> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51289

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unit test from this CL; part of another CL now #

Total comments: 8

Patch Set 3 : Address wtc's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -5 lines) Patch
M chrome/browser/renderer_host/resource_message_filter.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 2 4 chunks +38 lines, -4 lines 0 comments Download
Trybot results:
Commit:

Messages

Total messages: 6 (0 generated)
wtc
I only reviewed the new unit test in keygen_handler_unittest.cc. Just two nits below. (I understand ...
4 years, 8 months ago (2010-06-17 18:06:14 UTC) #1
David Benjamin
Split off the unit test onto http://codereview.chromium.org/2838010 and addressed comments. On 2010/06/17 18:06:14, wtc wrote: ...
4 years, 8 months ago (2010-06-17 18:23:12 UTC) #2
David Benjamin
4 years, 8 months ago (2010-06-24 20:48:57 UTC) #3
wtc
LGTM. Thanks for the hard work behind this CL! Note especially my last comment below. ...
4 years, 8 months ago (2010-06-25 00:21:11 UTC) #4
David Benjamin
http://codereview.chromium.org/2854007/diff/5001/6001 File chrome/browser/renderer_host/resource_message_filter.cc (right): http://codereview.chromium.org/2854007/diff/5001/6001#newcode1580 chrome/browser/renderer_host/resource_message_filter.cc:1580: const GURL& url, On 2010/06/25 00:21:11, wtc wrote: > ...
4 years, 8 months ago (2010-06-25 01:04:36 UTC) #5
wtc
4 years, 8 months ago (2010-06-25 02:07:15 UTC) #6
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87e6a26