components/content_settings/core/browser/content_settings_registry.cc - Issue 2853983002: Ensure settings returned from Content Settings providers are valid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/content_settings_registry.cc

Issue 2853983002: Ensure settings returned from Content Settings providers are valid (Closed)

Patch Set: Ensure settings returned from Content Settings providers are valid Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/content_settings/core/browser/content_settings_pref.cc ('k') | components/content_settings/core/browser/content_settings_registry_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/content_settings_registry.cc

diff --git a/components/content_settings/core/browser/content_settings_registry.cc b/components/content_settings/core/browser/content_settings_registry.cc

index b782ec646173a949210f44b1c3808b32abfcce2a..217e0a8eb282365058ac9a83f1cf7ba6543894c8 100644

--- a/components/content_settings/core/browser/content_settings_registry.cc

+++ b/components/content_settings/core/browser/content_settings_registry.cc

@@ -250,7 +250,8 @@ void ContentSettingsRegistry::Init() {

CONTENT_SETTING_ASK, WebsiteSettingsInfo::UNSYNCABLE,

WhitelistedSchemes(),

- ValidSettings(CONTENT_SETTING_ALLOW, CONTENT_SETTING_BLOCK),

+ ValidSettings(CONTENT_SETTING_ALLOW, CONTENT_SETTING_BLOCK,

+ CONTENT_SETTING_ASK),

WebsiteSettingsInfo::REQUESTING_ORIGIN_ONLY_SCOPE,

WebsiteSettingsRegistry::DESKTOP |

WebsiteSettingsRegistry::PLATFORM_ANDROID,