Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Unified Diff: components/content_settings/core/browser/content_settings_policy_provider.cc

Issue 2853983002: Ensure settings returned from Content Settings providers are valid (Closed)
Patch Set: Ensure settings returned from Content Settings providers are valid Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/browser/content_settings_policy_provider.cc
diff --git a/components/content_settings/core/browser/content_settings_policy_provider.cc b/components/content_settings/core/browser/content_settings_policy_provider.cc
index c2967aa41a68010245b9793394eef5705b3f06b6..d6548ce12ab372c93fcc8d1e2968c5e2e79e3d7e 100644
--- a/components/content_settings/core/browser/content_settings_policy_provider.cc
+++ b/components/content_settings/core/browser/content_settings_policy_provider.cc
@@ -13,6 +13,8 @@
#include "base/json/json_reader.h"
#include "base/macros.h"
#include "base/values.h"
+#include "components/content_settings/core/browser/content_settings_info.h"
+#include "components/content_settings/core/browser/content_settings_registry.h"
#include "components/content_settings/core/browser/content_settings_rule.h"
#include "components/content_settings/core/browser/content_settings_utils.h"
#include "components/content_settings/core/common/content_settings_pattern.h"
@@ -356,9 +358,14 @@ void PolicyProvider::UpdateManagedDefaultSetting(
ContentSettingsPattern::Wildcard(),
entry.content_type, std::string());
} else {
msramek 2017/05/03 20:05:42 style: } else if {
raymes 2017/05/04 05:49:14 Done.
- value_map_.SetValue(ContentSettingsPattern::Wildcard(),
- ContentSettingsPattern::Wildcard(), entry.content_type,
- std::string(), new base::Value(setting));
+ if (ContentSettingsRegistry::GetInstance()
+ ->Get(entry.content_type)
+ ->IsSettingValid(IntToContentSetting(setting))) {
+ value_map_.SetValue(ContentSettingsPattern::Wildcard(),
+ ContentSettingsPattern::Wildcard(),
+ entry.content_type, std::string(),
+ new base::Value(setting));
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698