Ensure settings returned from Content Settings providers are valid

chrome/browser/content_settings/content_settings_policy_provider_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/content_settings/core/browser/content_settings_policy_provider.h"
 
 #include <memory>
 #include <string>
 
 #include "base/auto_reset.h"
@@ skipping 53 matching lines @@
 
   provider.ShutdownOnUIThread();
 }
 
 TEST_F(PolicyProviderTest, ManagedDefaultContentSettings) {
   TestingProfile profile;
   sync_preferences::TestingPrefServiceSyncable* prefs =
       profile.GetTestingPrefService();
   PolicyProvider provider(prefs);
 
-  prefs->SetManagedPref(prefs::kManagedDefaultPluginsSetting,
+  prefs->SetManagedPref(prefs::kManagedDefaultCookiesSetting,
                         base::MakeUnique<base::Value>(CONTENT_SETTING_BLOCK));
 
   std::unique_ptr<RuleIterator> rule_iterator(provider.GetRuleIterator(
-      CONTENT_SETTINGS_TYPE_PLUGINS, std::string(), false));
+      CONTENT_SETTINGS_TYPE_COOKIES, std::string(), false));
   EXPECT_TRUE(rule_iterator->HasNext());
   Rule rule = rule_iterator->Next();
   EXPECT_FALSE(rule_iterator->HasNext());
 
   EXPECT_EQ(ContentSettingsPattern::Wildcard(), rule.primary_pattern);
   EXPECT_EQ(ContentSettingsPattern::Wildcard(), rule.secondary_pattern);
   EXPECT_EQ(CONTENT_SETTING_BLOCK, ValueToContentSetting(rule.value.get()));
 
   provider.ShutdownOnUIThread();
 }
@@ skipping 44 matching lines @@
 
   MockObserver mock_observer;
   EXPECT_CALL(mock_observer,
               OnContentSettingChanged(_,
                                       _,
                                       CONTENT_SETTINGS_TYPE_DEFAULT,
                                       ""));
   provider.AddObserver(&mock_observer);
 
   // Set the managed default-content-setting.
-  prefs->SetManagedPref(prefs::kManagedDefaultImagesSetting,
+  prefs->SetManagedPref(prefs::kManagedDefaultCookiesSetting,
                         base::MakeUnique<base::Value>(CONTENT_SETTING_BLOCK));
   ::testing::Mock::VerifyAndClearExpectations(&mock_observer);
   EXPECT_CALL(mock_observer,
               OnContentSettingChanged(_,
                                       _,
                                       CONTENT_SETTINGS_TYPE_DEFAULT,
                                       ""));
   // Remove the managed default-content-setting.
-  prefs->RemoveManagedPref(prefs::kManagedDefaultImagesSetting);
+  prefs->RemoveManagedPref(prefs::kManagedDefaultCookiesSetting);
   provider.ShutdownOnUIThread();
 }
 
 TEST_F(PolicyProviderTest, GettingManagedContentSettings) {
   TestingProfile profile;
   sync_preferences::TestingPrefServiceSyncable* prefs =
       profile.GetTestingPrefService();
 
   auto value = base::MakeUnique<base::ListValue>();
   value->AppendString("[*.]google.com");
@@ skipping 111 matching lines @@
 
   ASSERT_EQ(base::Value::Type::DICTIONARY, cert_filter->GetType());
   base::DictionaryValue* dict_value =
       static_cast<base::DictionaryValue*>(cert_filter.get());
   std::string actual_common_name;
   ASSERT_TRUE(dict_value->GetString("ISSUER.CN", &actual_common_name));
   EXPECT_EQ("issuer name", actual_common_name);
   provider.ShutdownOnUIThread();
 }
 
+TEST_F(PolicyProviderTest, InvalidManagedDefaultContentSetting) {
+  TestingProfile profile;
+  sync_preferences::TestingPrefServiceSyncable* prefs =
+      profile.GetTestingPrefService();
+  PolicyProvider provider(prefs);
+
+  prefs->SetManagedPref(
+      prefs::kManagedDefaultCookiesSetting,
+      base::MakeUnique<base::Value>(CONTENT_SETTING_DETECT_IMPORTANT_CONTENT));
+
+  // The setting provided in the cookies pref is not valid for cookies. It
+  // should be ignored.
+  std::unique_ptr<RuleIterator> rule_iterator(provider.GetRuleIterator(
+      CONTENT_SETTINGS_TYPE_COOKIES, std::string(), false));
+  EXPECT_FALSE(rule_iterator);
+
+  provider.ShutdownOnUIThread();
+}
+
 }  // namespace content_settings