Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2685)

Unified Diff: device/bluetooth/bluetooth_device_unittest.cc

Issue 2853933002: bluetooth: macOS: Support for extra didConnectPeripheral event from macOS. (Closed)
Patch Set: Adding Android bug Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/bluetooth/bluetooth_device.h ('k') | device/bluetooth/bluetooth_low_energy_device_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/bluetooth/bluetooth_device_unittest.cc
diff --git a/device/bluetooth/bluetooth_device_unittest.cc b/device/bluetooth/bluetooth_device_unittest.cc
index b19d78e6998dde3a7c449d763228e156bbd0c1cc..6d21ce721790767ebd19aa486a7d74df00dea68f 100644
--- a/device/bluetooth/bluetooth_device_unittest.cc
+++ b/device/bluetooth/bluetooth_device_unittest.cc
@@ -1015,6 +1015,7 @@ TEST_F(BluetoothTest,
return;
}
InitWithFakeAdapter();
+ TestBluetoothAdapterObserver observer(adapter_);
StartLowEnergyDiscoverySession();
BluetoothDevice* device = SimulateLowEnergyDevice(3);
@@ -1027,6 +1028,11 @@ TEST_F(BluetoothTest,
SimulateGattConnection(device);
base::RunLoop().RunUntilIdle();
+#if !defined(OS_ANDROID)
ortuno 2017/05/04 00:31:03 #if defined(OS_ANDROID) EXPECT_EQ(2, gatt_discov
jlebel 2017/05/04 01:18:38 Done.
+ // TODO(crbug.com/718168): on Android gatt_discovery_attempts_ is 2.
ortuno 2017/05/04 00:31:03 // Android incorrectly starts second discovery for
jlebel 2017/05/04 01:18:38 Done.
+ EXPECT_EQ(1, gatt_discovery_attempts_);
+#endif // !defined(OS_ANDROID)
+ EXPECT_EQ(2, observer.device_changed_count());
EXPECT_EQ(1, gatt_connection_attempts_);
EXPECT_EQ(1, callback_count_);
EXPECT_EQ(0, error_callback_count_);
« no previous file with comments | « device/bluetooth/bluetooth_device.h ('k') | device/bluetooth/bluetooth_low_energy_device_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698