components/tracing/child/child_trace_message_filter.cc - Issue 2853853002: Fix overflow when logging MaxInt32 to a sparse histogram.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/child/child_trace_message_filter.cc

Issue 2853853002: Fix overflow when logging MaxInt32 to a sparse histogram. (Closed)

Patch Set: Address comments. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/tracing/child/child_trace_message_filter.cc

diff --git a/components/tracing/child/child_trace_message_filter.cc b/components/tracing/child/child_trace_message_filter.cc

index 2cd76dc7b2a29242940e57591919b20ed36d828a..ce9c86f75f6ad48325a7445dc0b63e20016488eb 100644

--- a/components/tracing/child/child_trace_message_filter.cc

+++ b/components/tracing/child/child_trace_message_filter.cc

@@ -202,7 +202,7 @@ void ChildTraceMessageFilter::OnSetUMACallback(

while (!sample_iterator->Done()) {

base::HistogramBase::Sample min;

- base::HistogramBase::Sample max;

+ int64_t max;

base::HistogramBase::Count count;

sample_iterator->Get(&min, &max, &count);