Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 285383003: Add header required for cros build (Closed)

Created:
6 years, 7 months ago by achaulk
Modified:
6 years, 7 months ago
Reviewers:
gauravsh
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add header requires for cros build BUG=341554 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271162

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/feedback/feedback_uploader.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
achaulk
Not sure if you're a chromium committer or not
6 years, 7 months ago (2014-05-16 16:44:31 UTC) #1
gauravsh
lgtm Am a committer but you might need owners review though.
6 years, 7 months ago (2014-05-16 16:54:40 UTC) #2
achaulk
I added myself to the owners for this so this might work
6 years, 7 months ago (2014-05-16 16:55:32 UTC) #3
achaulk
The CQ bit was checked by achaulk@chromium.org
6 years, 7 months ago (2014-05-16 16:55:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achaulk@chromium.org/285383003/1
6 years, 7 months ago (2014-05-16 16:57:38 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 18:49:18 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 19:13:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/154541)
6 years, 7 months ago (2014-05-16 19:13:21 UTC) #8
achaulk
The CQ bit was checked by achaulk@chromium.org
6 years, 7 months ago (2014-05-16 19:13:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achaulk@chromium.org/285383003/1
6 years, 7 months ago (2014-05-16 19:15:35 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 21:00:19 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-17 04:54:43 UTC) #12
Message was sent while issue was closed.
Change committed as 271162

Powered by Google App Engine
This is Rietveld 408576698