Issue 2853813002: Fix patch errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2853813002: Fix patch errors. (Closed)

Created:
3 years, 7 months ago by floitsch

Modified:
3 years, 7 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix patch errors. Committed: https://github.com/dart-lang/sdk/commit/ff1d7488d97ca63dca5767f597a3eb24e8b551d4

Patch Set 1 #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -14 lines)			Patch
M	pkg/analysis_server/test/mock_sdk.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer/test/src/context/mock_sdk.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	pkg/dev_compiler/tool/input_sdk/patch/math_patch.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/lib/math_patch.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/math_patch.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

floitsch

Committed patchset #1 (id:1) manually as ff1d7488d97ca63dca5767f597a3eb24e8b551d4 (presubmit successful).

3 years, 7 months ago (2017-05-01 13:57:46 UTC) #4

Lasse Reichstein Nielsen

3 years, 7 months ago (2017-05-01 14:13:19 UTC) #5

Message was sent while issue was closed.

Changing the name of an external function and not changing the patch functions.
Duh on me!
(TBH, I forgot that there was non-comment changes at all in that CL).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages