chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.mm - Issue 2853803002: Make PermissionRequestManager::requests_ correspond to the active prompt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.mm

Issue 2853803002: Make PermissionRequestManager::requests_ correspond to the active prompt (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/permissions/permission_request_manager.cc ('K') | « chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.h ('k') | chrome/browser/ui/permission_bubble/mock_permission_prompt.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.mm b/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.mm

index edca45418cd0470a8d0c11d9c1ae02b988d49339..fc032b002e8ce9ae9058bb1f7b7444432e4b06b2 100644

--- a/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.mm

+++ b/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.mm

@@ -37,10 +37,6 @@ void PermissionBubbleCocoa::Hide() {

[bubbleController_ close];

}

-bool PermissionBubbleCocoa::IsVisible() {

- return bubbleController_ != nil;

void PermissionBubbleCocoa::SetDelegate(Delegate* delegate) {

if (delegate_ == delegate)

return;