Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2215)

Unified Diff: chrome/browser/permissions/permission_request_manager.h

Issue 2853803002: Make PermissionRequestManager::requests_ correspond to the active prompt (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_request_manager.h
diff --git a/chrome/browser/permissions/permission_request_manager.h b/chrome/browser/permissions/permission_request_manager.h
index 872fd8f50d2ba2a54f8558a69a80598a4e1eae53..af2d86426f3c54821aa332fd1755ad1e82aa443c 100644
--- a/chrome/browser/permissions/permission_request_manager.h
+++ b/chrome/browser/permissions/permission_request_manager.h
@@ -145,9 +145,12 @@ class PermissionRequestManager
// Posts a task which will allow the bubble to become visible if it is needed.
void ScheduleShowBubble();
- // Shows the bubble if it is not already visible and there are pending
- // requests.
- void TriggerShowBubble();
+ // If we aren't already showing a bubble, dequeue and show a pending request.
+ void DequeueRequestsAndShowBubble();
+
+ // Shows the bubble for a request that has just been dequeued, or re-show a
+ // bubble after switching tabs away and back.
+ void ShowBubble();
// Finalize the pending permissions request.
void FinalizeBubble();

Powered by Google App Engine
This is Rietveld 408576698