Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: chrome/browser/permissions/permission_prompt_android.cc

Issue 2853803002: Make PermissionRequestManager::requests_ correspond to the active prompt (Closed)
Patch Set: fix it? :D Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_prompt_android.h" 5 #include "chrome/browser/permissions/permission_prompt_android.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "chrome/browser/infobars/infobar_service.h" 8 #include "chrome/browser/infobars/infobar_service.h"
9 #include "chrome/browser/permissions/grouped_permission_infobar_delegate_android .h" 9 #include "chrome/browser/permissions/grouped_permission_infobar_delegate_android .h"
10 #include "chrome/browser/permissions/permission_request.h" 10 #include "chrome/browser/permissions/permission_request.h"
(...skipping 30 matching lines...) Expand all
41 bool PermissionPromptAndroid::HidesAutomatically() { 41 bool PermissionPromptAndroid::HidesAutomatically() {
42 return true; 42 return true;
43 } 43 }
44 44
45 void PermissionPromptAndroid::Hide() { 45 void PermissionPromptAndroid::Hide() {
46 // Hide() is only called if HidesAutomatically() returns false or 46 // Hide() is only called if HidesAutomatically() returns false or
47 // CanAcceptRequestUpdate() return true. 47 // CanAcceptRequestUpdate() return true.
48 NOTREACHED(); 48 NOTREACHED();
49 } 49 }
50 50
51 bool PermissionPromptAndroid::IsVisible() {
52 return !requests_.empty();
53 }
54
55 void PermissionPromptAndroid::UpdateAnchorPosition() { 51 void PermissionPromptAndroid::UpdateAnchorPosition() {
56 NOTREACHED() << "UpdateAnchorPosition is not implemented"; 52 NOTREACHED() << "UpdateAnchorPosition is not implemented";
57 } 53 }
58 54
59 gfx::NativeWindow PermissionPromptAndroid::GetNativeWindow() { 55 gfx::NativeWindow PermissionPromptAndroid::GetNativeWindow() {
60 NOTREACHED() << "GetNativeWindow is not implemented"; 56 NOTREACHED() << "GetNativeWindow is not implemented";
61 return nullptr; 57 return nullptr;
62 } 58 }
63 59
64 void PermissionPromptAndroid::Closing() { 60 void PermissionPromptAndroid::Closing() {
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 size_t position) const { 95 size_t position) const {
100 DCHECK_LT(position, requests_.size()); 96 DCHECK_LT(position, requests_.size());
101 return requests_[position]->GetMessageTextFragment(); 97 return requests_[position]->GetMessageTextFragment();
102 } 98 }
103 99
104 // static 100 // static
105 std::unique_ptr<PermissionPrompt> PermissionPrompt::Create( 101 std::unique_ptr<PermissionPrompt> PermissionPrompt::Create(
106 content::WebContents* web_contents) { 102 content::WebContents* web_contents) {
107 return base::MakeUnique<PermissionPromptAndroid>(web_contents); 103 return base::MakeUnique<PermissionPromptAndroid>(web_contents);
108 } 104 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698