Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: third_party/WebKit/Source/modules/csspaint/PaintWorklet.h

Issue 2853743002: Worklet: Introduce PaintWorkletGlobalScopeProxy (Closed)
Patch Set: address review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/csspaint/PaintWorklet.h
diff --git a/third_party/WebKit/Source/modules/csspaint/PaintWorklet.h b/third_party/WebKit/Source/modules/csspaint/PaintWorklet.h
index 762df33ed9afba7e6c2dbb44f1a5c7cf9ee27a3b..59c61e500d6619fb4320bab1922818ad34afa63e 100644
--- a/third_party/WebKit/Source/modules/csspaint/PaintWorklet.h
+++ b/third_party/WebKit/Source/modules/csspaint/PaintWorklet.h
@@ -7,7 +7,7 @@
#include "core/workers/MainThreadWorklet.h"
#include "modules/ModulesExport.h"
-#include "modules/csspaint/PaintWorkletGlobalScope.h"
+#include "modules/csspaint/PaintWorkletGlobalScopeProxy.h"
#include "platform/heap/Handle.h"
namespace blink {
@@ -15,6 +15,8 @@ namespace blink {
class CSSPaintDefinition;
class CSSPaintImageGeneratorImpl;
+// Manages a paint worklet:
+// https://drafts.css-houdini.org/css-paint-api/#dom-css-paintworklet
class MODULES_EXPORT PaintWorklet final : public MainThreadWorklet {
WTF_MAKE_NONCOPYABLE(PaintWorklet);
@@ -22,7 +24,7 @@ class MODULES_EXPORT PaintWorklet final : public MainThreadWorklet {
static PaintWorklet* Create(LocalFrame*);
~PaintWorklet() override;
- PaintWorkletGlobalScope* GetWorkletGlobalScopeProxy() const final;
+ WorkletGlobalScopeProxy* GetWorkletGlobalScopeProxy() const final;
CSSPaintDefinition* FindDefinition(const String& name);
void AddPendingGenerator(const String& name, CSSPaintImageGeneratorImpl*);
@@ -31,7 +33,8 @@ class MODULES_EXPORT PaintWorklet final : public MainThreadWorklet {
private:
explicit PaintWorklet(LocalFrame*);
- Member<PaintWorkletGlobalScope> paint_worklet_global_scope_;
+ // TODO(nhiroki): Make (Paint)WorkletGlobalScopeProxy GC-managed object.
+ std::unique_ptr<PaintWorkletGlobalScopeProxy> global_scope_proxy_;
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/modules/csspaint/BUILD.gn ('k') | third_party/WebKit/Source/modules/csspaint/PaintWorklet.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698