Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer_unittest.py

Issue 2853733003: webkitpy: Avoid to use webkit_base() and literal 'LayoutTests' in BaselineOptimizer (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer_unittest.py
index 7514e04f01fb91c57259505d3666d18c3833d7a3..f7f142ba960297d1c05c1ae2073d0a6d5cbf7c57 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer_unittest.py
@@ -38,20 +38,20 @@ class BaselineOptimizerTest(unittest.TestCase):
def _assert_optimization(self, results_by_directory, directory_to_new_results, baseline_dirname='', host=None):
host = host or MockHost()
fs = host.filesystem
- webkit_base = WebKitFinder(fs).webkit_base()
+ layout_tests_dir = WebKitFinder(fs).layout_tests_dir()
baseline_name = 'mock-baseline-expected.txt'
fs.write_text_file(
- fs.join(webkit_base, 'LayoutTests', 'VirtualTestSuites'),
+ fs.join(layout_tests_dir, 'VirtualTestSuites'),
'[{"prefix": "gpu", "base": "fast/canvas", "args": ["--foo"]}]')
for dirname, contents in results_by_directory.items():
- fs.write_binary_file(fs.join(webkit_base, 'LayoutTests', dirname, baseline_name), contents)
+ fs.write_binary_file(fs.join(layout_tests_dir, dirname, baseline_name), contents)
baseline_optimizer = BaselineOptimizer(host, host.port_factory.get(), host.port_factory.all_port_names())
self.assertTrue(baseline_optimizer.optimize(fs.join(baseline_dirname, baseline_name)))
for dirname, contents in directory_to_new_results.items():
- path = fs.join(webkit_base, 'LayoutTests', dirname, baseline_name)
+ path = fs.join(layout_tests_dir, dirname, baseline_name)
if contents is not None:
self.assertEqual(fs.read_binary_file(path), contents)
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698