Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 285373015: Gallery.app: Replace the existing gallery with the new separated gallery. (Closed)

Created:
6 years, 7 months ago by hirono
Modified:
6 years, 7 months ago
Reviewers:
mtomasz, benwells
CC:
chromium-reviews, extensions-reviews_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Gallery.app: Replace the existing gallery with the new separated gallery. This CL starts to use the new separated gallery without specifying the file-manager-enable-new-gallery flag. BUG=358698 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271546

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Remove gallery tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -231 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_manager_browsertest/manifest.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/file_manager_browsertest/open_special_types.js View 1 2 1 chunk +0 lines, -141 lines 0 comments Download
A + chrome/test/data/extensions/api_test/file_manager_browsertest/open_zip_files.js View 1 2 2 chunks +0 lines, -61 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager/manifest.json View 1 chunk +0 lines, -15 lines 0 comments Download
M ui/file_manager/gallery/manifest.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 7 months ago (2014-05-19 06:53:54 UTC) #1
mtomasz
lgtm
6 years, 7 months ago (2014-05-19 07:32:06 UTC) #2
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 7 months ago (2014-05-19 08:08:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/285373015/20001
6 years, 7 months ago (2014-05-19 08:09:15 UTC) #4
hirono
The CQ bit was unchecked by hirono@chromium.org
6 years, 7 months ago (2014-05-19 08:09:17 UTC) #5
hirono
On 2014/05/19 08:09:17, hirono wrote: > The CQ bit was unchecked by mailto:hirono@chromium.org @mtomasz - ...
6 years, 7 months ago (2014-05-19 08:29:54 UTC) #6
mtomasz
On 2014/05/19 08:29:54, hirono wrote: > On 2014/05/19 08:09:17, hirono wrote: > > The CQ ...
6 years, 7 months ago (2014-05-19 08:37:30 UTC) #7
hirono
On 2014/05/19 08:37:30, mtomasz wrote: > On 2014/05/19 08:29:54, hirono wrote: > > On 2014/05/19 ...
6 years, 7 months ago (2014-05-19 08:42:24 UTC) #8
hirono
@benwells - PTAL component_loader.cc? Thank you!
6 years, 7 months ago (2014-05-19 09:34:14 UTC) #9
benwells
lgtm
6 years, 7 months ago (2014-05-20 01:23:17 UTC) #10
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 7 months ago (2014-05-20 01:31:07 UTC) #11
hirono
On 2014/05/20 01:23:17, benwells wrote: > lgtm Thank you!
6 years, 7 months ago (2014-05-20 01:31:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/285373015/40001
6 years, 7 months ago (2014-05-20 01:31:20 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 02:53:22 UTC) #14
Message was sent while issue was closed. 
Change committed as 271546

Powered by Google App Engine
This is Rietveld 408576698