Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: LayoutTests/inspector/jump-to-previous-editing-location.html

Issue 285373011: DevTools: excessive dumping for jump-to-previous-position.html test (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/inspector/jump-to-previous-editing-location-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/inspector/jump-to-previous-editing-location.html
diff --git a/LayoutTests/inspector/jump-to-previous-editing-location.html b/LayoutTests/inspector/jump-to-previous-editing-location.html
index 2fbd279c225f72c92d7d5154826816c664770ee1..e041dc501c490b8123105217774b063f956ab940 100644
--- a/LayoutTests/inspector/jump-to-previous-editing-location.html
+++ b/LayoutTests/inspector/jump-to-previous-editing-location.html
@@ -177,6 +177,20 @@ function test()
function testHistoryDepth(next)
{
+ function dumpSimpleHistoryManagerState(title)
+ {
+ var simpleHistoryManager = historyManager._historyManager;
+ var entries = simpleHistoryManager._entries;
+ InspectorTest.addResult("=== SimpleHistoryManager state " + title + " ===");
+ InspectorTest.addResult("entries count: " + entries.length);
+ for (var i = entries.length - 1; i >= 0; --i) {
+ var position = entries[i]._positionHandle.resolve();
+ var positionText = position ? "{line: " + position.lineNumber + ", column: " + position.columnNumber + "}" : position + "";
+ var positionMarker = simpleHistoryManager._activeEntryIndex === i ? ">" : " ";
+ InspectorTest.addResult(positionMarker + "entry[" + i + "] = " + positionText);
+ }
+ InspectorTest.addResult("=== ===");
+ }
var lines = [];
var columns = [];
const jumpsAmount = WebInspector.EditingLocationHistoryManager.HistoryDepth;
@@ -185,8 +199,17 @@ function test()
columns.push(7);
}
var editor = panel.visibleView.textEditor;
+ //FIXME(lushnikov): here and below excessive dumping to figure out a reason for
+ // unreproducible bot failures.
+ dumpSimpleHistoryManagerState("before filling history stack");
clickAndDump(editor, lines, columns);
- for (var i = 0; i < jumpsAmount; ++i) {
+ dumpSimpleHistoryManagerState("after filling history stack");
+
+ InspectorTest.addResult("First rollback result: " + historyManager._historyManager.rollback());
+ dumpSimpleHistoryManagerState("after first rollback");
+ dumpSelection(editor, "Rolled back");
+
+ for (var i = 0; i < jumpsAmount - 1; ++i) {
rollback();
dumpSelection(editor, "Rolled back");
}
« no previous file with comments | « no previous file | LayoutTests/inspector/jump-to-previous-editing-location-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698