Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 285373010: Remove check for full-page plugin when handling unsupported PDF feature (Closed)

Created:
6 years, 7 months ago by raymes
Modified:
6 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Remove check for full-page plugin when handling unsupported PDF feature The out of process PDF plugin is never a "full-page" plugin because it is always embedded in an extension. There is a check inside the PDF plugin to make sure is being loaded in the top frame before calling this function. BUG=303491 R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271584

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/renderer/pepper/pepper_pdf_host.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
raymes
6 years, 7 months ago (2014-05-19 01:56:14 UTC) #1
raymes
On 2014/05/19 01:56:14, raymes wrote: Note that this only affects the out of process case.
6 years, 7 months ago (2014-05-19 01:56:31 UTC) #2
jam
lgtm
6 years, 7 months ago (2014-05-19 17:02:50 UTC) #3
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 7 months ago (2014-05-20 01:56:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/285373010/1
6 years, 7 months ago (2014-05-20 01:56:39 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 05:48:09 UTC) #6
raymes
6 years, 7 months ago (2014-05-20 06:28:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r271584 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698