Android: Decouple animate from vsync

content/browser/renderer_host/compositor_impl_android.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_COMPOSITOR_IMPL_ANDROID_H_
 #define CONTENT_BROWSER_RENDERER_HOST_COMPOSITOR_IMPL_ANDROID_H_
 
 #include "base/basictypes.h"
+#include "base/cancelable_callback.h"
 #include "base/compiler_specific.h"
 #include "base/containers/scoped_ptr_hash_map.h"
 #include "base/memory/scoped_ptr.h"
-#include "base/memory/weak_ptr.h"
 #include "cc/resources/ui_resource_client.h"
 #include "cc/trees/layer_tree_host_client.h"
 #include "cc/trees/layer_tree_host_single_thread_client.h"
 #include "content/browser/renderer_host/image_transport_factory_android.h"
 #include "content/common/content_export.h"
 #include "content/public/browser/android/compositor.h"
 #include "third_party/khronos/GLES2/gl2.h"
 #include "ui/base/android/window_android_compositor.h"
 
 class SkBitmap;
@@ skipping 74 matching lines @@
 
   // ImageTransportFactoryAndroidObserver implementation.
   virtual void OnLostResources() OVERRIDE;
 
   // WindowAndroidCompositor implementation.
   virtual void AttachLayerForReadback(scoped_refptr<cc::Layer> layer) OVERRIDE;
   virtual void RequestCopyOfOutputOnRootLayer(
       scoped_ptr<cc::CopyOutputRequest> request) OVERRIDE;
   virtual void OnVSync(base::TimeTicks frame_time,
                        base::TimeDelta vsync_period) OVERRIDE;
+  virtual void SetNeedsAnimate() OVERRIDE;
 
-  void PostComposite(base::TimeDelta delay);
   enum CompositingTrigger {
+    DO_NOT_COMPOSITE,
     COMPOSITE_IMMEDIATELY,
-    COMPOSITE_ON_VSYNC
+    COMPOSITE_EVENTUALLY,
   };
+  void PostComposite(CompositingTrigger trigger);
   void Composite(CompositingTrigger trigger);
+
+  bool WillCompositeThisFrame() {

[Sami, 2014/05/27 19:54:05]

nit: These three methods could be const.

[no sievers, 2014/05/27 20:05:17]

Done.

+    return current_composite_task_ &&
+           !current_composite_task_->callback().is_null();
+  }
+  bool DidCompositeThisFrame() {
+    return current_composite_task_ &&
+           current_composite_task_->callback().is_null();
+  }
+  bool WillComposite() {
+    return WillCompositeThisFrame() ||
+           composite_on_vsync_trigger_ != DO_NOT_COMPOSITE;
+  }
+  void CancelComposite() {
+    DCHECK(WillComposite());
+    if (WillCompositeThisFrame())
+      current_composite_task_->Cancel();
+    current_composite_task_.reset();
+    composite_on_vsync_trigger_ = DO_NOT_COMPOSITE;
+    will_composite_immediately_ = false;
+  }
   cc::UIResourceId GenerateUIResourceFromUIResourceBitmap(
       const cc::UIResourceBitmap& bitmap,
       bool is_transient);
 
   scoped_refptr<cc::Layer> root_layer_;
   scoped_ptr<cc::LayerTreeHost> host_;
 
   gfx::Size size_;
   bool has_transparent_background_;
   float device_scale_factor_;
@@ skipping 13 matching lines @@
   // a posted SwapBuffers().
   bool did_post_swapbuffers_;
 
   // Used locally to inhibit ScheduleComposite() during Layout().
   bool ignore_schedule_composite_;
 
   // Whether we need to composite in general because of any invalidation or
   // explicit request.
   bool needs_composite_;
 
-  // When SetNeedsComposite() is getting called, we will try to schedule
-  // regularly during vsync.
-  bool should_composite_on_vsync_;
+  // Whether we need to update animations on the next composite.
+  bool needs_animate_;
 
-  // Whether we composited already in the current vsync interval.
-  bool did_composite_this_frame_;
+  // Whether we posted a task and are about to composite.
+  bool will_composite_immediately_;
+
+  // How we should schedule Composite during the next vsync.
+  CompositingTrigger composite_on_vsync_trigger_;
+
+  // The Composite operation scheduled for the current vsync interval.
+  scoped_ptr<base::CancelableClosure> current_composite_task_;
 
   // The number of SwapBuffer calls that have not returned and ACK'd from
   // the GPU thread.
   unsigned int pending_swapbuffers_;
 
   base::TimeDelta vsync_period_;
-
-  base::WeakPtrFactory<CompositorImpl> weak_factory_;
+  base::TimeTicks last_vsync_;
 
   DISALLOW_COPY_AND_ASSIGN(CompositorImpl);
 };
 
 } // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_COMPOSITOR_IMPL_ANDROID_H_