Reland "cc: Remove layers that are not drawn from tile manager."

Reland "cc: Remove layers that are not drawn from tile manager."

cc: Remove layers that are not drawn from tile manager.

This patch removes layers that are no longer have their tile priorities
updated from tile manager, in order to ensure that we don't process
tile or use any other information from these layers.

R=enne
BUG=176557, 358350
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271143

[vmpstr, 2014-05-15 17:38:53]

Hi,

This is my proposed fix for the increase in crash rates. I do believe that
https://codereview.chromium.org/287643004 might make the comment and the if
statement not needed, so I'm more than willing to wait until that lands. 

On the flip side, I feel that any time we decide to remove tilings on the
pending layer, we should require post commit initialization, to ensure that any
calls that somehow end up calling ManageTilings will first sync from active
layer.

[enne (OOO), 2014-05-15 17:41:32]

https://codereview.chromium.org/285373003/diff/1/cc/layers/picture_layer_impl.cc
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/285373003/diff/1/cc/layers/picture_layer_impl...
cc/layers/picture_layer_impl.cc:381: needs_post_commit_initialization_ = true;
:(

Just wait for https://codereview.chromium.org/271533011

[vmpstr, 2014-05-15 17:48:28]

On 2014/05/15 17:41:32, enne wrote:
>
https://codereview.chromium.org/285373003/diff/1/cc/layers/picture_layer_impl.cc
> File cc/layers/picture_layer_impl.cc (right):
> 
>
https://codereview.chromium.org/285373003/diff/1/cc/layers/picture_layer_impl...
> cc/layers/picture_layer_impl.cc:381: needs_post_commit_initialization_ = true;
> :(
> 
> Just wait for https://codereview.chromium.org/271533011

Oops, I pasted the wrong review, yes that's the one I meant I can wait for :P

[vmpstr, 2014-05-16 18:02:45]

Please take a look.

I've removed the remove all tilings thing for now, since the real intent of this
patch is to make sure that tile manager doesn't deal with stale layers. The
patch accomplishes that. RemoveAllTilings is a nice addition, which I will put
in separately once Sohan's patch lands.

[enne (OOO), 2014-05-16 18:04:09]

lgtm

[vmpstr, 2014-05-16 18:12:45]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2014-05-16 18:13:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vmpstr@chromium.org/285373003/40001

[commit-bot: I haz the power, 2014-05-16 21:11:57]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[vmpstr, 2014-05-16 21:37:38]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2014-05-16 23:32:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vmpstr@chromium.org/285373003/40001

[commit-bot: I haz the power, 2014-05-17 01:49:39]

Change committed as 271143