Cleanup unused class/includes device(motion|orientation)

Cleanup unused class/includes device(motion|orientation)

DeviceMotionService was replaced by the more general
device_inertial_sensor_service class in r219007.
Cleaning up a the leftovers and some unused class/includes.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272253

[riju_, 2014-05-15 15:37:14]

Hi Tim : Please have a look.

[riju_, 2014-05-19 15:09:04]

On 2014/05/15 15:37:14, riju_ wrote:
> Hi Tim : Please have a look.

Friendly ping :)

[timvolodine, 2014-05-21 17:53:13]

yes looks like there are some unnecessary bits, thanks for fixing this. comments
below.

https://codereview.chromium.org/285373002/diff/1/content/browser/device_senso...
File content/browser/device_sensors/device_inertial_sensor_service.cc (right):

https://codereview.chromium.org/285373002/diff/1/content/browser/device_senso...
content/browser/device_sensors/device_inertial_sensor_service.cc:93: void
DeviceInertialSensorService::SetDataFetcherForTests(
while we are at it, could you change this to:
"SetDataFetcherForTests" ->"SetDataFetcherForTesting"
and also in the tests of course.

https://codereview.chromium.org/285373002/diff/1/content/browser/device_senso...
File content/browser/device_sensors/device_inertial_sensor_service.h (right):

https://codereview.chromium.org/285373002/diff/1/content/browser/device_senso...
content/browser/device_sensors/device_inertial_sensor_service.h:21: // Owns the
Device(Motion|Orientation)Provider (the background polling thread)
could you replace the whole comment with:
"Owns the data fetcher for Device Motion and Orientation and keeps track of the
number of consumers currently using the data. The data fetcher is stopped when
there are no consumers."

[riju_, 2014-05-22 11:34:30]

Thanks Tim for the comments

https://codereview.chromium.org/285373002/diff/1/content/browser/device_senso...
File content/browser/device_sensors/device_inertial_sensor_service.cc (right):

https://codereview.chromium.org/285373002/diff/1/content/browser/device_senso...
content/browser/device_sensors/device_inertial_sensor_service.cc:93: void
DeviceInertialSensorService::SetDataFetcherForTests(
On 2014/05/21 17:53:13, timvolodine wrote:
> while we are at it, could you change this to:
> "SetDataFetcherForTests" ->"SetDataFetcherForTesting"
> and also in the tests of course.

Done.

https://codereview.chromium.org/285373002/diff/1/content/browser/device_senso...
File content/browser/device_sensors/device_inertial_sensor_service.h (right):

https://codereview.chromium.org/285373002/diff/1/content/browser/device_senso...
content/browser/device_sensors/device_inertial_sensor_service.h:21: // Owns the
Device(Motion|Orientation)Provider (the background polling thread)
On 2014/05/21 17:53:13, timvolodine wrote:
> could you replace the whole comment with:
> "Owns the data fetcher for Device Motion and Orientation and keeps track of
the
> number of consumers currently using the data. The data fetcher is stopped when
> there are no consumers."

Done.

[timvolodine, 2014-05-22 13:53:43]

lgtm

[riju_, 2014-05-22 14:13:37]

The CQ bit was checked by rijubrata.bhaumik@intel.com

[commit-bot: I haz the power, 2014-05-22 14:14:54]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/rijubrata.bhaumik@intel.com/285373002/...

[commit-bot: I haz the power, 2014-05-22 18:48:22]

Change committed as 272253