Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4076)

Unified Diff: chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeTabUtils.java

Issue 2853573002: Convert ChromeTabbedActivityTestCaseBase children to JUnit4 (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeTabUtils.java
diff --git a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeTabUtils.java b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeTabUtils.java
index 078e566913d045da6e01c2cfc7c6c79b325275e1..8c25e7154c5b59db7d4d8095a1c637c4a1bbf840 100644
--- a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeTabUtils.java
+++ b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeTabUtils.java
@@ -5,10 +5,9 @@
package org.chromium.chrome.test.util;
import android.app.Instrumentation;
-import android.test.InstrumentationTestCase;
import android.text.TextUtils;
-import junit.framework.Assert;
+import org.junit.Assert;
import org.chromium.base.Log;
import org.chromium.base.ThreadUtils;
@@ -28,7 +27,7 @@ import org.chromium.chrome.browser.tabmodel.TabModel.TabSelectionType;
import org.chromium.chrome.browser.tabmodel.TabModelObserver;
import org.chromium.chrome.browser.tabmodel.TabModelSelector;
import org.chromium.chrome.browser.tabmodel.TabModelUtils;
-import org.chromium.chrome.test.ChromeTabbedActivityTestBase;
+import org.chromium.content.browser.test.util.TouchCommon;
import org.chromium.content_public.browser.LoadUrlParams;
import org.chromium.ui.base.DeviceFormFactor;
@@ -253,9 +252,9 @@ public class ChromeTabUtils {
* <p>
* Does not wait for the tab to be loaded.
*/
- public static void clickNewTabButton(InstrumentationTestCase test,
- ChromeTabbedActivityTestBase base) throws InterruptedException {
- final TabModel normalTabModel = base.getActivity().getTabModelSelector().getModel(false);
+ public static void clickNewTabButton(Instrumentation instrumentation,
+ ChromeTabbedActivity activity) throws InterruptedException {
+ final TabModel normalTabModel = activity.getTabModelSelector().getModel(false);
final CallbackHelper createdCallback = new CallbackHelper();
normalTabModel.addObserver(
new EmptyTabModelObserver() {
@@ -266,14 +265,14 @@ public class ChromeTabUtils {
}
});
// Tablet and phone have different new tab buttons; click the right one.
- if (DeviceFormFactor.isTablet(base.getActivity())) {
+ if (DeviceFormFactor.isTablet(activity)) {
StripLayoutHelper strip =
- TabStripUtils.getStripLayoutHelper(base.getActivity(), false /* incognito */);
+ TabStripUtils.getStripLayoutHelper(activity, false /* incognito */);
CompositorButton newTabButton = strip.getNewTabButton();
- TabStripUtils.clickCompositorButton(newTabButton, base);
- test.getInstrumentation().waitForIdleSync();
+ TabStripUtils.clickCompositorButton(newTabButton, instrumentation, activity);
+ instrumentation.waitForIdleSync();
} else {
- base.singleClickView(base.getActivity().findViewById(R.id.new_tab_button));
+ TouchCommon.singleClickView(activity.findViewById(R.id.new_tab_button));
}
try {

Powered by Google App Engine
This is Rietveld 408576698