Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/IncognitoTabModelTest.java

Issue 2853573002: Convert ChromeTabbedActivityTestCaseBase children to JUnit4 (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/IncognitoTabModelTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/IncognitoTabModelTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/IncognitoTabModelTest.java
index ccf980536b7dd95accb61f957105accc461980ba..3069669f3deb10045b4ecedc509c4fd25f6a1af0 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/IncognitoTabModelTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/IncognitoTabModelTest.java
@@ -6,24 +6,42 @@ package org.chromium.chrome.browser.tabmodel;
import android.support.test.filters.SmallTest;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+
import org.chromium.base.ThreadUtils;
+import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.RetryOnFailure;
+import org.chromium.chrome.browser.ChromeSwitches;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;
-import org.chromium.chrome.test.ChromeTabbedActivityTestBase;
+import org.chromium.chrome.test.ChromeActivityTestRule;
+import org.chromium.chrome.test.ChromeJUnit4ClassRunner;
+import org.chromium.chrome.test.ChromeTabbedActivityTestRule;
import org.chromium.content_public.browser.LoadUrlParams;
/**
* Tests for IncognitoTabModel.
*/
-public class IncognitoTabModelTest extends ChromeTabbedActivityTestBase {
+@RunWith(ChromeJUnit4ClassRunner.class)
+@CommandLineFlags.Add({
+ ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE,
+ ChromeActivityTestRule.DISABLE_NETWORK_PREDICTION_FLAG,
+})
+public class IncognitoTabModelTest {
+ @Rule
+ public ChromeTabbedActivityTestRule mActivityTestRule = new ChromeTabbedActivityTestRule();
+
private TabModel mTabModel;
- @Override
- public void startMainActivity() throws InterruptedException {
- startMainActivityOnBlankPage();
- mTabModel = getActivity().getTabModelSelector().getModel(true);
+ @Before
+ public void setUp() throws InterruptedException {
+ mActivityTestRule.startMainActivityOnBlankPage();
+ mTabModel = mActivityTestRule.getActivity().getTabModelSelector().getModel(true);
}
private class CloseAllDuringAddTabTabModelObserver extends EmptyTabModelObserver {
@@ -37,8 +55,8 @@ public class IncognitoTabModelTest extends ChromeTabbedActivityTestBase {
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
@Override
public void run() {
- getActivity().getTabCreator(true).createNewTab(new LoadUrlParams("about:blank"),
- TabLaunchType.FROM_CHROME_UI, null);
+ mActivityTestRule.getActivity().getTabCreator(true).createNewTab(
+ new LoadUrlParams("about:blank"), TabLaunchType.FROM_CHROME_UI, null);
}
});
}
@@ -49,14 +67,15 @@ public class IncognitoTabModelTest extends ChromeTabbedActivityTestBase {
* "Close all incognito tabs" then quickly clicks the "+" button to add a new incognito tab.
* See crbug.com/496651.
*/
+ @Test
@SmallTest
@Feature({"OffTheRecord"})
@RetryOnFailure
public void testCloseAllDuringAddTabDoesNotCrash() {
createTabOnUiThread();
- assertEquals(1, mTabModel.getCount());
+ Assert.assertEquals(1, mTabModel.getCount());
mTabModel.addObserver(new CloseAllDuringAddTabTabModelObserver());
createTabOnUiThread();
- assertEquals(1, mTabModel.getCount());
+ Assert.assertEquals(1, mTabModel.getCount());
}
}

Powered by Google App Engine
This is Rietveld 408576698