chrome/browser/resources/settings/internet_page/network_property_list.js - Issue 2853563002: ONC: Translate EAP from Shill to ONC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/network_property_list.js

Issue 2853563002: ONC: Translate EAP from Shill to ONC (Closed)

Patch Set: Use params Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/internet_page/network_property_list.html ('k') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('j') | components/onc/docs/onc_spec.md » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/network_property_list.js

diff --git a/chrome/browser/resources/settings/internet_page/network_property_list.js b/chrome/browser/resources/settings/internet_page/network_property_list.js

index ce5d805ff5caddaa74a8b75113d0100d27097274..fd434561add374e0d2712a47c8179d102b77539a 100644

--- a/chrome/browser/resources/settings/internet_page/network_property_list.js

+++ b/chrome/browser/resources/settings/internet_page/network_property_list.js

@@ -103,13 +103,16 @@ Polymer({

/**

* Generates a filter function dependent on propertyDict and editFieldTypes.

+ * @param {string} prefix

+ * @param {!Object} propertyDict

+ * @param {!Object} editFieldTypes

* @private

- computeFilter_: function() {

+ computeFilter_: function(prefix, propertyDict, editFieldTypes) {

return function(key) {

- if (this.editFieldTypes.hasOwnProperty(key))

+ if (editFieldTypes.hasOwnProperty(key))

return true;

- var value = this.get(key, this.propertyDict);

+ var value = this.getPropertyValue_(key, prefix, propertyDict);

return value !== undefined && value !== '';

}.bind(this);