Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2853543002: Temporarily disable overlapping summary check (Closed)

Created:
3 years, 7 months ago by vsm
Modified:
3 years, 7 months ago
Reviewers:
keertip
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Temporarily disable overlapping summary check Turning this off to unblock the current roll. We'll try flipping the flag internally and shaking out the last violators. R=keertip@google.com Committed: https://github.com/dart-lang/sdk/commit/334373b1dcfbf75d041b0d1077129d920d09d185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M pkg/dev_compiler/lib/src/compiler/compiler.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/dev_compiler/test/worker/worker_test.dart View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
3 years, 7 months ago (2017-04-28 17:53:16 UTC) #3
keertip
lgtm
3 years, 7 months ago (2017-04-28 18:01:02 UTC) #4
vsm
3 years, 7 months ago (2017-04-28 18:08:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
334373b1dcfbf75d041b0d1077129d920d09d185 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698