Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: base/i18n/base_i18n_switches.cc

Issue 2853523002: [rendertext,i18n] Added flag to force RTL rendering (Closed)
Patch Set: Corrected ordering and text, added cached look-ups Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/i18n/base_i18n_switches.cc
diff --git a/base/i18n/base_i18n_switches.cc b/base/i18n/base_i18n_switches.cc
index 44e8393baab0b90c6e8bc53180d21482d6f09d5e..81777813c3474b1515fa451eea7b52720d1fab2f 100644
--- a/base/i18n/base_i18n_switches.cc
+++ b/base/i18n/base_i18n_switches.cc
@@ -10,7 +10,12 @@ namespace switches {
// and "rtl" (right-to-left).
const char kForceUIDirection[] = "force-ui-direction";
-const char kForceUIDirectionLTR[] = "ltr";
-const char kForceUIDirectionRTL[] = "rtl";
+// Force the text rendering to a specific direction. Valid values are "ltr"
+// (left-to-right) and "rtl" (right-to-left). Only tested meaningfully with
+// RTL.
+const char kForceTextDirection[] = "force-text-direction";
+
+const char kForceDirectionLTR[] = "ltr";
msw 2017/05/01 20:56:18 optional nit: shrink the spacing before '=' here a
Kevin Bailey 2017/05/01 21:21:42 Done. Agreed, looks better.
+const char kForceDirectionRTL[] = "rtl";
} // namespace switches

Powered by Google App Engine
This is Rietveld 408576698