Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 285343004: [AiS] Extract Answers, store on AutocompleteMatch. (Closed)

Created:
6 years, 7 months ago by groby-ooo-7-16
Modified:
6 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Visibility:
Public.

Description

[AiS] Extract Answers, store on AutocompleteMatch. This extracts Answers from the results JSON, if they exist, and make sure they're available on AutocompleteMatch objects. BUG=370192 R=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270906

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -11 lines) Patch
M chrome/browser/autocomplete/autocomplete_match.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/base_search_provider.h View 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/base_search_provider.cc View 8 chunks +23 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 3 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
groby-ooo-7-16
6 years, 7 months ago (2014-05-15 22:12:17 UTC) #1
Peter Kasting
LGTM
6 years, 7 months ago (2014-05-15 22:15:02 UTC) #2
groby-ooo-7-16
The CQ bit was checked by groby@chromium.org
6 years, 7 months ago (2014-05-15 22:36:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/285343004/1
6 years, 7 months ago (2014-05-15 22:37:04 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 00:40:03 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 01:03:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/27615)
6 years, 7 months ago (2014-05-16 01:03:14 UTC) #7
groby-ooo-7-16
The CQ bit was checked by groby@chromium.org
6 years, 7 months ago (2014-05-16 01:09:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/285343004/1
6 years, 7 months ago (2014-05-16 01:09:51 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 02:50:11 UTC) #10
Message was sent while issue was closed.
Change committed as 270906

Powered by Google App Engine
This is Rietveld 408576698