Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Unified Diff: src/code-stub-assembler.cc

Issue 2853393002: [builtins] Migrate Object.keys to CodeStubAssembler builtin. (Closed)
Patch Set: Properly handle the empty case. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/code-stub-assembler.cc
diff --git a/src/code-stub-assembler.cc b/src/code-stub-assembler.cc
index b14031b4c715dfb804c6e5230630de5e2d838fec..c3c16d7e6e1bee210f6eefb48a2334ca2582ef7b 100644
--- a/src/code-stub-assembler.cc
+++ b/src/code-stub-assembler.cc
@@ -3155,20 +3155,23 @@ Node* CodeStubAssembler::IsJSReceiverInstanceType(Node* instance_type) {
Int32Constant(FIRST_JS_RECEIVER_TYPE));
}
+Node* CodeStubAssembler::IsJSReceiverMap(Node* map) {
+ return IsJSReceiverInstanceType(LoadMapInstanceType(map));
+}
+
Node* CodeStubAssembler::IsJSReceiver(Node* object) {
- STATIC_ASSERT(LAST_JS_OBJECT_TYPE == LAST_TYPE);
- return IsJSReceiverInstanceType(LoadInstanceType(object));
+ return IsJSReceiverMap(LoadMap(object));
}
-Node* CodeStubAssembler::IsJSReceiverMap(Node* map) {
+Node* CodeStubAssembler::IsJSObjectMap(Node* map) {
STATIC_ASSERT(LAST_JS_OBJECT_TYPE == LAST_TYPE);
- return IsJSReceiverInstanceType(LoadMapInstanceType(map));
+ CSA_ASSERT(this, IsMap(map));
+ return Int32GreaterThanOrEqual(LoadMapInstanceType(map),
+ Int32Constant(FIRST_JS_OBJECT_TYPE));
}
Node* CodeStubAssembler::IsJSObject(Node* object) {
- STATIC_ASSERT(LAST_JS_OBJECT_TYPE == LAST_TYPE);
- return Int32GreaterThanOrEqual(LoadInstanceType(object),
- Int32Constant(FIRST_JS_RECEIVER_TYPE));
+ return IsJSObjectMap(LoadMap(object));
}
Node* CodeStubAssembler::IsJSGlobalProxy(Node* object) {
« no previous file with comments | « src/code-stub-assembler.h ('k') | src/keys.cc » ('j') | test/mjsunit/object-keys.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698