Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2380)

Unified Diff: chrome/android/BUILD.gn

Issue 2853373005: Android: Enable --long-plt for arm32 when order profiling is enabled. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index 48f5d395a33f053f29dced488d2fcd7d6df87eab..a8358b8c61f4a6f741544d38f7deb8b915f65985 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -644,12 +644,12 @@ shared_library("chrome") {
[ "//third_party/gvr-android-sdk/libgvr_shim_static_${current_cpu}.a" ]
}
- if (is_android && use_order_profiling) {
+ if (use_order_profiling) {
deps += [ "//tools/cygprofile" ]
}
- # See crbug.com/705088 for more info.
- if (is_android && target_cpu == "arm" && is_asan) {
+ # See crbug.com/705088, crbug.com/717815.
+ if (target_cpu == "arm" && (is_asan || use_order_profiling)) {
ldflags = [ "-Wl,--long-plt" ]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698