Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 285333004: Add maniscalco@ to OWNERS files. (Closed)

Created:
6 years, 7 months ago by pavely
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, arv+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Put names in alphabetical order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M chrome/browser/resources/sync_internals/OWNERS View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/OWNERS View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/sync/OWNERS View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/OWNERS View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/sync_driver/OWNERS View 1 1 chunk +2 lines, -1 line 0 comments Download
M sync/OWNERS View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
pavely
6 years, 7 months ago (2014-05-16 22:27:13 UTC) #1
pavely
+blundell@ for components/OWNERS
6 years, 7 months ago (2014-05-16 22:27:33 UTC) #2
tim (not reviewing)
LGTM
6 years, 7 months ago (2014-05-16 22:56:30 UTC) #3
blundell
lgtm https://codereview.chromium.org/285333004/diff/1/chrome/browser/resources/sync_internals/OWNERS File chrome/browser/resources/sync_internals/OWNERS (right): https://codereview.chromium.org/285333004/diff/1/chrome/browser/resources/sync_internals/OWNERS#newcode8 chrome/browser/resources/sync_internals/OWNERS:8: pavely@chromium.org nit: in general, OWNERS files are kept ...
6 years, 7 months ago (2014-05-19 07:35:48 UTC) #4
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 7 months ago (2014-05-19 16:52:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/285333004/20001
6 years, 7 months ago (2014-05-19 16:53:14 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 20:40:27 UTC) #7
Message was sent while issue was closed.
Change committed as 271467

Powered by Google App Engine
This is Rietveld 408576698