Capture and report stdout/stderr of the browser while running a test

tools/testing/dart/test_runner.dart

Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index d817a9e466ebba9b96855703dc2247b1be216a3e..e84ee23c5d3b81911c59b1077e0e6abc00b2d22e 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -17,11 +17,9 @@ import "dart:convert" show LineSplitter, UTF8;
 // We need to use the 'io' prefix here, otherwise io.exitCode will shadow
 // CommandOutput.exitCode in subclasses of CommandOutput.
 import "dart:io" as io;
-import "dart:isolate";
 import "dart:math" as math;
 import 'dependency_graph.dart' as dgraph;
 import "browser_controller.dart";
-import "http_server.dart" as http_server;
 import "status_file_parser.dart";
 import "test_progress.dart";
 import "test_suite.dart";
@@ -1994,25 +1992,30 @@ class CommandExecutorImpl implements CommandExecutor {
       BrowserTestCommand browserCommand, int timeout) {
     var completer = new Completer<CommandOutput>();
 
-    var callback = (output, delayUntilTestStarted, duration) {
-      bool timedOut = output == "TIMEOUT";
+    var callback = (BrowserTestOutput output) {
+      bool timedOut = output.didTimeout;
       String stderr = "";
       if (timedOut) {
-        if (delayUntilTestStarted != null) {
-          stderr = "This test timed out. The delay until the test was actually "
-                   "started was: $delayUntilTestStarted.";
+        if (output.delayUntilTestStarted != null) {
+          stderr = "This test timed out. The delay until the test actually "
+                   "started was: ${output.delayUntilTestStarted}.";
         } else {
           stderr = "This test has not notified test.py that it started running."
                    " This could be a bug in test.py! "
                    "Please contact ricow/kustermann";
         }
       }
+      stderr = [stderr, '',
+                'BrowserOutput while running the test (this may be incorrect):',

[ricow1, 2013/10/18 14:00:42]

I would prefix this line with * EXPERIMENTAL * instead of saying this may be
incorrect

[kustermann, 2013/10/18 15:28:27]

Done.

+                'BrowserOutput.stdout:', output.browserOutput.stdout.toString(),
+                'BrowserOutput.stderr:', output.browserOutput.stderr.toString()]
+          .join('\n');

[ricow1, 2013/10/18 14:00:42]

why do you create an array here, why don't you just use string interpolation?

[kustermann, 2013/10/18 15:28:27]

Done.

       var commandOutput = createCommandOutput(browserCommand,
                           0,
                           timedOut,
-                          encodeUtf8(output),
+                          encodeUtf8(output.dom),
                           encodeUtf8(stderr),
-                          duration,
+                          output.duration,
                           false);
       completer.complete(commandOutput);
     };