Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2853203002: Change Future.doWhile to use a loop for non-future results instead of recursion. (Closed)

Created:
3 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 7 months ago
Reviewers:
floitsch, sra1
CC:
reviews_dartlang.org, keertip
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change Future.doWhile to use a loop for non-future results instead of recursion. Avoids stack overflow on long sequences of non-future results. R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/8c742bd500747c2f9a3e7d8a1559d79cac99ffb1

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -5 lines) Patch
M sdk/lib/async/future.dart View 1 2 chunks +5 lines, -4 lines 0 comments Download
M tests/lib/async/futures_test.dart View 2 chunks +27 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Lasse Reichstein Nielsen
3 years, 7 months ago (2017-05-02 07:21:47 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/2853203002/diff/1/sdk/lib/async/future.dart File sdk/lib/async/future.dart (right): https://codereview.chromium.org/2853203002/diff/1/sdk/lib/async/future.dart#newcode487 sdk/lib/async/future.dart:487: // context of all the previous iterations' callbacks. ...
3 years, 7 months ago (2017-05-02 10:16:56 UTC) #3
Lasse Reichstein Nielsen
3 years, 7 months ago (2017-05-02 10:57:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8c742bd500747c2f9a3e7d8a1559d79cac99ffb1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698