Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2853183002: fix bots: do not analyze front_end when analyzing dart2js, they need to be (Closed)

Created:
3 years, 7 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 7 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix bots: do not analyze front_end when analyzing dart2js, they need to be analyzed with incompatible options (strong vs not-strong). pkg/front_end is anyways analyzed in the front_end tests, so I believe this is safe to exclude here. BUG= Committed: https://github.com/dart-lang/sdk/commit/7ece6d94a2443f4c5028b729d1edd850962c5e40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/compiler/testing.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Siggi Cherem (dart-lang)
TBR
3 years, 7 months ago (2017-05-02 02:39:38 UTC) #3
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as 7ece6d94a2443f4c5028b729d1edd850962c5e40 (presubmit successful).
3 years, 7 months ago (2017-05-02 02:39:56 UTC) #5
sra1
3 years, 7 months ago (2017-05-02 02:52:32 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698