chrome/browser/ui/views/payments/payment_sheet_view_controller.cc - Issue 2853163002: [Web Payments] Implement proper focusing in Payment Request

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/payment_sheet_view_controller.cc

Issue 2853163002: [Web Payments] Implement proper focusing in Payment Request (Closed)

Patch Set: Allow ViewControllers to specify their first focused view Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/payments/payment_sheet_view_controller.cc

diff --git a/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc b/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc

index e413ea99d97e6ed0a127fb2d019dc89afb57e809..5426d8cb40c3131e064880a3070226fcd5b25612 100644

--- a/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc

+++ b/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc

@@ -441,7 +441,8 @@ void PaymentSheetViewController::FillContentView(views::View* content_view) {

// The shipping address and contact info rows are optional.

layout->StartRow(0, 0);

- layout->AddView(CreatePaymentSheetSummaryRow().release());

+ std::unique_ptr<views::View> summary_row = CreatePaymentSheetSummaryRow();

Mathieu 2017/05/02 13:16:10 need this change?

anthonyvd 2017/05/02 13:43:32 Oops, not anymore.

+ layout->AddView(summary_row.release());

if (spec()->request_shipping()) {

layout->StartRow(0, 0);