Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: ios/chrome/browser/ui/omnibox_perftest.mm

Issue 2853153002: Disabled a few more failing perf tests (Closed)
Patch Set: removed unintentional change. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/omnibox_perftest.mm
diff --git a/ios/chrome/browser/ui/omnibox_perftest.mm b/ios/chrome/browser/ui/omnibox_perftest.mm
index 9605ada33d493c43748c9a7eed3a5c1b044b33c3..69e0b80f6bfdb438679675a321308da81decefcb 100644
--- a/ios/chrome/browser/ui/omnibox_perftest.mm
+++ b/ios/chrome/browser/ui/omnibox_perftest.mm
@@ -215,7 +215,8 @@ class OmniboxPerfTest : public PerfTest {
// Measures the amount of time it takes the Omnibox text field to activate
// the on-screen keyboard.
-TEST_F(OmniboxPerfTest, TestTextFieldDidBeginEditing) {
+// TODO(crbug.com/717300): Test disabled because of a DCHECK in Reading List.
+TEST_F(OmniboxPerfTest, DISABLED_TestTextFieldDidBeginEditing) {
LogPerfTiming("Keyboard preload", PreLoadKeyboard());
OmniboxTextFieldIOS* textField = (OmniboxTextFieldIOS*)FindViewByClass(
[toolbar_ view], [OmniboxTextFieldIOS class]);
@@ -232,7 +233,8 @@ TEST_F(OmniboxPerfTest, TestTextFieldDidBeginEditing) {
// Measures the amount of time it takes to type in the first character
// into the Omnibox.
-TEST_F(OmniboxPerfTest, TestTypeOneCharInTextField) {
+// TODO(crbug.com/717309): Test disabled because of nullptr dereferencing.
+TEST_F(OmniboxPerfTest, DISABLED_TestTypeOneCharInTextField) {
OmniboxTextFieldIOS* textField = (OmniboxTextFieldIOS*)FindViewByClass(
[toolbar_ view], [OmniboxTextFieldIOS class]);
RepeatTimedRuns("Type first character",
@@ -248,7 +250,8 @@ TEST_F(OmniboxPerfTest, TestTypeOneCharInTextField) {
// Measures the amount of time it takes to type in the word "google" one
// letter at a time.
-TEST_F(OmniboxPerfTest, TestTypingInTextField) {
+// TODO(crbug.com/717309): Test disabled because of nullptr dereferencing.
+TEST_F(OmniboxPerfTest, DISABLED_TestTypingInTextField) {
OmniboxTextFieldIOS* textField = (OmniboxTextFieldIOS*)FindViewByClass(
[toolbar_ view], [OmniboxTextFieldIOS class]);
// The characters to type into the omnibox text field.
« no previous file with comments | « ios/chrome/browser/ui/ntp/new_tab_page_perftest.mm ('k') | ios/chrome/browser/ui/stack_view/stack_view_controller_perftest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698