Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: chrome/browser/ui/views/permission_bubble/chooser_bubble_ui.h

Issue 2853143003: MacViews: Allows the toolkit-views Device Chooser bubble to be used (Closed)
Patch Set: MacViews: Allows the toolkit-views Device Chooser bubble to be used (nits) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/permission_bubble/chooser_bubble_ui.h
diff --git a/chrome/browser/ui/views/permission_bubble/chooser_bubble_ui_view.h b/chrome/browser/ui/views/permission_bubble/chooser_bubble_ui.h
similarity index 66%
rename from chrome/browser/ui/views/permission_bubble/chooser_bubble_ui_view.h
rename to chrome/browser/ui/views/permission_bubble/chooser_bubble_ui.h
index e2385a0a2a486ef9c99ea918f9ede14a472ccbe2..2e6baf16a7103e0761c67e483dd31486ce90c456 100644
--- a/chrome/browser/ui/views/permission_bubble/chooser_bubble_ui_view.h
+++ b/chrome/browser/ui/views/permission_bubble/chooser_bubble_ui.h
@@ -2,16 +2,18 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_UI_VIEWS_PERMISSION_BUBBLE_CHOOSER_BUBBLE_UI_VIEW_H_
-#define CHROME_BROWSER_UI_VIEWS_PERMISSION_BUBBLE_CHOOSER_BUBBLE_UI_VIEW_H_
+#ifndef CHROME_BROWSER_UI_VIEWS_PERMISSION_BUBBLE_CHOOSER_BUBBLE_UI_H_
+#define CHROME_BROWSER_UI_VIEWS_PERMISSION_BUBBLE_CHOOSER_BUBBLE_UI_H_
#include <memory>
#include "base/macros.h"
#include "components/bubble/bubble_ui.h"
+#include "ui/gfx/geometry/point.h"
#include "ui/views/bubble/bubble_border.h"
namespace views {
+class BubbleDialogDelegateView;
class View;
}
@@ -19,16 +21,16 @@ class Browser;
class ChooserController;
class ChooserBubbleUiViewDelegate;
-// ChooserBubbleUiView implements a chooser-based permission model,
+// ChooserBubbleUi implements a chooser-based permission model,
// it uses table view to show a list of items (such as usb devices, etc.)
// for user to grant permission. It can be used by the WebUSB or WebBluetooth
// APIs. It is owned by the BubbleController, which is owned by the
// BubbleManager.
-class ChooserBubbleUiView : public BubbleUi {
+class ChooserBubbleUi : public BubbleUi {
public:
- ChooserBubbleUiView(Browser* browser,
- std::unique_ptr<ChooserController> chooser_controller);
- ~ChooserBubbleUiView() override;
+ ChooserBubbleUi(Browser* browser,
+ std::unique_ptr<ChooserController> chooser_controller);
+ ~ChooserBubbleUi() override;
// BubbleUi:
void Show(BubbleReference bubble_reference) override;
@@ -36,14 +38,18 @@ class ChooserBubbleUiView : public BubbleUi {
void UpdateAnchorPosition() override;
private:
+ // These functions have separate implementations for Views-based and
+ // Cocoa-based browsers, to allow this bubble to be used in either.
+ void CreateAndShow(views::BubbleDialogDelegateView* delegate);
views::View* GetAnchorView();
+ gfx::Point GetAnchorPoint();
views::BubbleBorder::Arrow GetAnchorArrow();
Browser* browser_; // Weak.
// Weak. Owned by its parent view.
ChooserBubbleUiViewDelegate* chooser_bubble_ui_view_delegate_;
- DISALLOW_COPY_AND_ASSIGN(ChooserBubbleUiView);
+ DISALLOW_COPY_AND_ASSIGN(ChooserBubbleUi);
};
-#endif // CHROME_BROWSER_UI_VIEWS_PERMISSION_BUBBLE_CHOOSER_BUBBLE_UI_VIEW_H_
+#endif // CHROME_BROWSER_UI_VIEWS_PERMISSION_BUBBLE_CHOOSER_BUBBLE_UI_H_

Powered by Google App Engine
This is Rietveld 408576698