chrome/browser/ui/cocoa/permission_bubble/chooser_bubble_ui_cocoa.mm - Issue 2853143003: MacViews: Allows the toolkit-views Device Chooser bubble to be used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/permission_bubble/chooser_bubble_ui_cocoa.mm

Issue 2853143003: MacViews: Allows the toolkit-views Device Chooser bubble to be used (Closed)

Patch Set: MacViews: Allows the toolkit-views Device Chooser bubble to be used Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/cocoa/permission_bubble/chooser_bubble_ui_views_mac.mm » ('j') | chrome/browser/ui/cocoa/permission_bubble/chooser_bubble_ui_views_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/permission_bubble/chooser_bubble_ui_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/permission_bubble/chooser_bubble_ui_cocoa.mm b/chrome/browser/ui/cocoa/permission_bubble/chooser_bubble_ui_cocoa.mm

index 5950ab6a72d4d75efe4ba67df4ec653481ac8fb0..1cc5d92b7805bf738d03e2137140e1066d76cf3b 100644

--- a/chrome/browser/ui/cocoa/permission_bubble/chooser_bubble_ui_cocoa.mm

+++ b/chrome/browser/ui/cocoa/permission_bubble/chooser_bubble_ui_cocoa.mm

@@ -22,17 +22,11 @@

#import "chrome/browser/ui/cocoa/info_bubble_view.h"

#import "chrome/browser/ui/cocoa/info_bubble_window.h"

#import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"

-#include "chrome/browser/ui/permission_bubble/chooser_bubble_delegate.h"

#include "components/bubble/bubble_controller.h"

#include "content/public/browser/native_web_keyboard_event.h"

#include "ui/base/cocoa/cocoa_base_utils.h"

#include "ui/base/cocoa/window_size_constants.h"

-std::unique_ptr<BubbleUi> ChooserBubbleDelegate::BuildBubbleUi() {

- return base::MakeUnique<ChooserBubbleUiCocoa>(browser_,

- std::move(chooser_controller_));

@interface ChooserBubbleUiController

: BaseBubbleController<NSTableViewDataSource, NSTableViewDelegate> {

@private