chrome/browser/ui/cocoa/permission_bubble/permission_prompt_impl_views_mac.mm - Issue 2853143003: MacViews: Allows the toolkit-views Device Chooser bubble to be used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/permission_bubble/permission_prompt_impl_views_mac.mm

Issue 2853143003: MacViews: Allows the toolkit-views Device Chooser bubble to be used (Closed)

Patch Set: MacViews: Allows the toolkit-views Device Chooser bubble to be used (swizzling tests) Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller_unittest.mm ('k') | chrome/browser/ui/views/permission_bubble/chooser_bubble_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/permission_bubble/permission_prompt_impl_views_mac.mm

diff --git a/chrome/browser/ui/cocoa/permission_bubble/permission_prompt_impl_views_mac.mm b/chrome/browser/ui/cocoa/permission_bubble/permission_prompt_impl_views_mac.mm

index 79c8a95bae319ac04c0101d319119188267bdc15..8822b745e25ad3e658a505adea5e8383a1f02d0c 100644

--- a/chrome/browser/ui/cocoa/permission_bubble/permission_prompt_impl_views_mac.mm

+++ b/chrome/browser/ui/cocoa/permission_bubble/permission_prompt_impl_views_mac.mm

@@ -7,6 +7,7 @@

#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/browser_window.h"

#import "chrome/browser/ui/cocoa/browser_window_controller.h"

+#import "chrome/browser/ui/cocoa/bubble_anchor_helper.h"

#import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"

#import "chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.h"

#import "chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.h"

@@ -24,8 +25,8 @@ views::View* PermissionPromptImpl::GetAnchorView() {

}

gfx::Point PermissionPromptImpl::GetAnchorPoint() {

- return gfx::ScreenPointFromNSPoint(

- [PermissionBubbleController getAnchorPointForBrowser:browser_]);

+ return gfx::ScreenPointFromNSPoint(GetPermissionBubbleAnchorPointForBrowser(

+ browser_, HasVisibleLocationBarForBrowser(browser_)));

varkha 2017/05/03 08:47:03 I could be not making this change, see which looks

tapted 2017/05/03 09:09:11 this is good - it's probably showing up somewhere

}

views::BubbleBorder::Arrow PermissionPromptImpl::GetAnchorArrow() {