Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Side by Side Diff: chrome/browser/ui/views/permission_bubble/chooser_bubble_ui.cc

Issue 2853143003: MacViews: Allows the toolkit-views Device Chooser bubble to be used (Closed)
Patch Set: MacViews: Allows the toolkit-views Device Chooser bubble to be used (nits) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/permission_bubble/chooser_bubble_ui_view.h" 5 #include "chrome/browser/ui/views/permission_bubble/chooser_bubble_ui.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 10
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "base/memory/ptr_util.h" 12 #include "base/memory/ptr_util.h"
13 #include "base/strings/string16.h" 13 #include "base/strings/string16.h"
14 #include "chrome/browser/chooser_controller/chooser_controller.h" 14 #include "chrome/browser/chooser_controller/chooser_controller.h"
15 #include "chrome/browser/ui/browser.h" 15 #include "chrome/browser/ui/browser.h"
16 #include "chrome/browser/ui/browser_window.h" 16 #include "chrome/browser/ui/browser_window.h"
17 #include "chrome/browser/ui/permission_bubble/chooser_bubble_delegate.h" 17 #include "chrome/browser/ui/permission_bubble/chooser_bubble_delegate.h"
18 #include "chrome/browser/ui/views/device_chooser_content_view.h" 18 #include "chrome/browser/ui/views/device_chooser_content_view.h"
19 #include "chrome/browser/ui/views/exclusive_access_bubble_views.h"
20 #include "chrome/browser/ui/views/frame/browser_view.h"
21 #include "chrome/browser/ui/views/frame/top_container_view.h"
22 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
23 #include "chrome/browser/ui/views/location_bar/location_icon_view.h"
24 #include "components/bubble/bubble_controller.h" 19 #include "components/bubble/bubble_controller.h"
25 #include "ui/views/controls/image_view.h" 20 #include "ui/views/bubble/bubble_dialog_delegate.h"
26 #include "ui/views/controls/link.h" 21 #include "ui/views/controls/link.h"
27 #include "ui/views/controls/styled_label.h" 22 #include "ui/views/controls/styled_label.h"
28 #include "ui/views/controls/table/table_view_observer.h" 23 #include "ui/views/controls/table/table_view_observer.h"
29 #include "ui/views/window/dialog_client_view.h" 24 #include "ui/views/window/dialog_client_view.h"
30 25
31 std::unique_ptr<BubbleUi> ChooserBubbleDelegate::BuildBubbleUi() {
32 return base::MakeUnique<ChooserBubbleUiView>(browser_,
33 std::move(chooser_controller_));
34 }
35
36 /////////////////////////////////////////////////////////////////////////////// 26 ///////////////////////////////////////////////////////////////////////////////
37 // View implementation for the chooser bubble. 27 // View implementation for the chooser bubble.
38 class ChooserBubbleUiViewDelegate : public views::BubbleDialogDelegateView, 28 class ChooserBubbleUiViewDelegate : public views::BubbleDialogDelegateView,
39 public views::TableViewObserver { 29 public views::TableViewObserver {
40 public: 30 public:
41 ChooserBubbleUiViewDelegate( 31 ChooserBubbleUiViewDelegate(
42 views::View* anchor_view, 32 views::View* anchor_view,
33 const gfx::Point& anchor_point,
43 views::BubbleBorder::Arrow anchor_arrow, 34 views::BubbleBorder::Arrow anchor_arrow,
44 std::unique_ptr<ChooserController> chooser_controller); 35 std::unique_ptr<ChooserController> chooser_controller);
45 ~ChooserBubbleUiViewDelegate() override; 36 ~ChooserBubbleUiViewDelegate() override;
46 37
47 // views::WidgetDelegate: 38 // views::WidgetDelegate:
48 base::string16 GetWindowTitle() const override; 39 base::string16 GetWindowTitle() const override;
49 40
50 // views::DialogDelegate: 41 // views::DialogDelegate:
51 base::string16 GetDialogButtonLabel(ui::DialogButton button) const override; 42 base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;
52 bool IsDialogButtonEnabled(ui::DialogButton button) const override; 43 bool IsDialogButtonEnabled(ui::DialogButton button) const override;
(...skipping 20 matching lines...) Expand all
73 64
74 private: 65 private:
75 DeviceChooserContentView* device_chooser_content_view_; 66 DeviceChooserContentView* device_chooser_content_view_;
76 BubbleReference bubble_reference_; 67 BubbleReference bubble_reference_;
77 68
78 DISALLOW_COPY_AND_ASSIGN(ChooserBubbleUiViewDelegate); 69 DISALLOW_COPY_AND_ASSIGN(ChooserBubbleUiViewDelegate);
79 }; 70 };
80 71
81 ChooserBubbleUiViewDelegate::ChooserBubbleUiViewDelegate( 72 ChooserBubbleUiViewDelegate::ChooserBubbleUiViewDelegate(
82 views::View* anchor_view, 73 views::View* anchor_view,
74 const gfx::Point& anchor_point,
83 views::BubbleBorder::Arrow anchor_arrow, 75 views::BubbleBorder::Arrow anchor_arrow,
84 std::unique_ptr<ChooserController> chooser_controller) 76 std::unique_ptr<ChooserController> chooser_controller)
85 : views::BubbleDialogDelegateView(anchor_view, anchor_arrow), 77 : views::BubbleDialogDelegateView(anchor_view, anchor_arrow),
86 device_chooser_content_view_(nullptr) { 78 device_chooser_content_view_(nullptr) {
87 // ------------------------------------ 79 // ------------------------------------
88 // | Chooser bubble title | 80 // | Chooser bubble title |
89 // | -------------------------------- | 81 // | -------------------------------- |
90 // | | option 0 | | 82 // | | option 0 | |
91 // | | option 1 | | 83 // | | option 1 | |
92 // | | option 2 | | 84 // | | option 2 | |
93 // | | | | 85 // | | | |
94 // | | | | 86 // | | | |
95 // | | | | 87 // | | | |
96 // | -------------------------------- | 88 // | -------------------------------- |
97 // | [ Connect ] [ Cancel ] | 89 // | [ Connect ] [ Cancel ] |
98 // |----------------------------------| 90 // |----------------------------------|
99 // | Get help | 91 // | Get help |
100 // ------------------------------------ 92 // ------------------------------------
101 93
102 device_chooser_content_view_ = 94 device_chooser_content_view_ =
103 new DeviceChooserContentView(this, std::move(chooser_controller)); 95 new DeviceChooserContentView(this, std::move(chooser_controller));
96 if (!anchor_view)
97 SetAnchorRect(gfx::Rect(anchor_point, gfx::Size()));
104 } 98 }
105 99
106 ChooserBubbleUiViewDelegate::~ChooserBubbleUiViewDelegate() {} 100 ChooserBubbleUiViewDelegate::~ChooserBubbleUiViewDelegate() {}
107 101
108 base::string16 ChooserBubbleUiViewDelegate::GetWindowTitle() const { 102 base::string16 ChooserBubbleUiViewDelegate::GetWindowTitle() const {
109 return device_chooser_content_view_->GetWindowTitle(); 103 return device_chooser_content_view_->GetWindowTitle();
110 } 104 }
111 105
112 base::string16 ChooserBubbleUiViewDelegate::GetDialogButtonLabel( 106 base::string16 ChooserBubbleUiViewDelegate::GetDialogButtonLabel(
113 ui::DialogButton button) const { 107 ui::DialogButton button) const {
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 BubbleReference bubble_reference) { 168 BubbleReference bubble_reference) {
175 bubble_reference_ = bubble_reference; 169 bubble_reference_ = bubble_reference;
176 DCHECK(bubble_reference_); 170 DCHECK(bubble_reference_);
177 } 171 }
178 172
179 void ChooserBubbleUiViewDelegate::UpdateTableView() const { 173 void ChooserBubbleUiViewDelegate::UpdateTableView() const {
180 device_chooser_content_view_->UpdateTableView(); 174 device_chooser_content_view_->UpdateTableView();
181 } 175 }
182 176
183 ////////////////////////////////////////////////////////////////////////////// 177 //////////////////////////////////////////////////////////////////////////////
184 // ChooserBubbleUiView 178 // ChooserBubbleUi
185 ChooserBubbleUiView::ChooserBubbleUiView( 179 ChooserBubbleUi::ChooserBubbleUi(
186 Browser* browser, 180 Browser* browser,
187 std::unique_ptr<ChooserController> chooser_controller) 181 std::unique_ptr<ChooserController> chooser_controller)
188 : browser_(browser), chooser_bubble_ui_view_delegate_(nullptr) { 182 : browser_(browser), chooser_bubble_ui_view_delegate_(nullptr) {
189 DCHECK(browser_); 183 DCHECK(browser_);
190 DCHECK(chooser_controller); 184 DCHECK(chooser_controller);
191 chooser_bubble_ui_view_delegate_ = new ChooserBubbleUiViewDelegate( 185 chooser_bubble_ui_view_delegate_ = new ChooserBubbleUiViewDelegate(
192 GetAnchorView(), GetAnchorArrow(), std::move(chooser_controller)); 186 GetAnchorView(), GetAnchorPoint(), GetAnchorArrow(),
187 std::move(chooser_controller));
193 } 188 }
194 189
195 ChooserBubbleUiView::~ChooserBubbleUiView() {} 190 ChooserBubbleUi::~ChooserBubbleUi() {}
196 191
197 void ChooserBubbleUiView::Show(BubbleReference bubble_reference) { 192 void ChooserBubbleUi::Show(BubbleReference bubble_reference) {
198 chooser_bubble_ui_view_delegate_->set_bubble_reference(bubble_reference); 193 chooser_bubble_ui_view_delegate_->set_bubble_reference(bubble_reference);
199 194 CreateAndShow(chooser_bubble_ui_view_delegate_);
200 // Set |parent_window| because some valid anchors can become hidden.
201 views::Widget* widget = views::Widget::GetWidgetForNativeWindow(
202 browser_->window()->GetNativeWindow());
203 chooser_bubble_ui_view_delegate_->set_parent_window(widget->GetNativeView());
204
205 views::BubbleDialogDelegateView::CreateBubble(
206 chooser_bubble_ui_view_delegate_)
207 ->Show();
208
209 chooser_bubble_ui_view_delegate_->UpdateTableView(); 195 chooser_bubble_ui_view_delegate_->UpdateTableView();
210 } 196 }
211 197
212 void ChooserBubbleUiView::Close() {} 198 void ChooserBubbleUi::Close() {}
213 199
214 void ChooserBubbleUiView::UpdateAnchorPosition() { 200 void ChooserBubbleUi::UpdateAnchorPosition() {
215 chooser_bubble_ui_view_delegate_->UpdateAnchor(GetAnchorView(), 201 chooser_bubble_ui_view_delegate_->UpdateAnchor(GetAnchorView(),
216 GetAnchorArrow()); 202 GetAnchorArrow());
217 } 203 }
218
219 views::View* ChooserBubbleUiView::GetAnchorView() {
220 BrowserView* browser_view = BrowserView::GetBrowserViewForBrowser(browser_);
221
222 if (browser_->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR))
223 return browser_view->GetLocationBarView()
224 ->location_icon_view()
225 ->GetImageView();
226
227 if (browser_view->IsFullscreenBubbleVisible())
228 return browser_view->exclusive_access_bubble()->GetView();
229
230 return browser_view->top_container();
231 }
232
233 views::BubbleBorder::Arrow ChooserBubbleUiView::GetAnchorArrow() {
234 if (browser_->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR))
235 return views::BubbleBorder::TOP_LEFT;
236 return views::BubbleBorder::NONE;
237 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698