MacViews: Allows the toolkit-views Device Chooser bubble to be used

chrome/browser/ui/views/permission_bubble/chooser_bubble_ui_views.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/macros.h"
+#include "base/memory/ptr_util.h"
+#include "chrome/browser/chooser_controller/chooser_controller.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/permission_bubble/chooser_bubble_delegate.h"
+#include "chrome/browser/ui/views/exclusive_access_bubble_views.h"
+#include "chrome/browser/ui/views/frame/browser_view.h"
+#include "chrome/browser/ui/views/frame/top_container_view.h"
+#include "chrome/browser/ui/views/location_bar/location_bar_view.h"
+#include "chrome/browser/ui/views/location_bar/location_icon_view.h"
+#include "chrome/browser/ui/views/permission_bubble/chooser_bubble_ui.h"

[juncai, 2017/05/04 18:27:15]

maybe move this include to the top of the include list and add an extra line
after it since this .cc file implements it.

[varkha, 2017/05/05 18:23:29]

Done.

+#include "ui/views/controls/image_view.h"
+
+// The Views browser implementation of ChooserBubbleUi's anchor methods.
+// Views browsers have a native View to anchor the bubble to, which these
+// functions provide.
+
+std::unique_ptr<BubbleUi> ChooserBubbleDelegate::BuildBubbleUi() {
+  return base::MakeUnique<ChooserBubbleUi>(browser_,
+                                           std::move(chooser_controller_));
+}
+
+void ChooserBubbleUi::CreateAndShow(views::BubbleDialogDelegateView* delegate) {
+  // Set |parent_window| because some valid anchors can become hidden.

[juncai, 2017/05/04 18:27:15]

nit: s/|parent_window|/|parent_window_|

[varkha, 2017/05/05 18:23:29]

Done.

+  views::Widget* widget = views::Widget::GetWidgetForNativeWindow(
+      browser_->window()->GetNativeWindow());
+  gfx::NativeView parent = widget->GetNativeView();
+  DCHECK(parent);
+  delegate->set_parent_window(parent);
+  views::BubbleDialogDelegateView::CreateBubble(delegate)->Show();
+}
+
+views::View* ChooserBubbleUi::GetAnchorView() {
+  BrowserView* browser_view = BrowserView::GetBrowserViewForBrowser(browser_);
+
+  if (browser_->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR)) {
+    return browser_view->GetLocationBarView()
+        ->location_icon_view()
+        ->GetImageView();
+  }
+  if (browser_view->IsFullscreenBubbleVisible())
+    return browser_view->exclusive_access_bubble()->GetView();
+
+  return browser_view->top_container();
+}
+
+gfx::Point ChooserBubbleUi::GetAnchorPoint() {
+  return gfx::Point();
+}
+
+views::BubbleBorder::Arrow ChooserBubbleUi::GetAnchorArrow() {
+  if (browser_->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR))
+    return views::BubbleBorder::TOP_LEFT;
+  return views::BubbleBorder::NONE;
+}