MacViews: Allows the toolkit-views Device Chooser bubble to be used

chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.h"
 
 #include <Carbon/Carbon.h>
 
 #include "base/mac/foundation_util.h"
 #import "base/mac/scoped_objc_class_swizzler.h"
@@ skipping 21 matching lines @@
 #import "ui/events/test/cocoa_test_event_utils.h"
 
 @class ConstrainedWindowButton;
 
 @interface PermissionBubbleController (ExposedForTesting)
 - (void)ok:(id)sender;
 - (void)onAllow:(id)sender;
 - (void)onBlock:(id)sender;
 - (void)onCustomize:(id)sender;
 - (void)onCheckboxChanged:(id)sender;
-+ (NSInteger)getFullscreenLeftOffset;
 @end
 
 @interface SplitBlockButton (ExposedForTesting)
 - (NSMenu*)menu;
 @end
 
 @interface MockBubbleYesLocationBar : NSObject
 @end
 
 @implementation MockBubbleYesLocationBar
@@ skipping 333 matching lines @@
   NSWindow* window = browser()->window()->GetNativeWindow();
   BrowserWindowController* controller =
       [BrowserWindowController browserWindowControllerForWindow:window];
   LocationBarViewMac* location_bar_bridge = [controller locationBarBridge];
   NSPoint expected = location_bar_bridge->GetPageInfoBubblePoint();
   expected = ui::ConvertPointFromWindowToScreen(window, expected);
   EXPECT_NSEQ(expected, anchor);
 }
 
 TEST_F(PermissionBubbleControllerTest, AnchorPositionWithoutLocationBar) {
+  // Constant offset from the left to use for fullscreen permission bubbles.

[tapted, 2017/05/03 09:09:11]

See bubble_anchor_helper.mm?

[varkha, 2017/05/03 09:22:40]

Done.

+  const NSInteger kFullscreenLeftOffset = 40;
+
   base::mac::ScopedObjCClassSwizzler locationSwizzle(
       [PermissionBubbleController class], [MockBubbleNoLocationBar class],
       @selector(hasVisibleLocationBarForBrowser:));
 
   NSPoint anchor = [controller_ getExpectedAnchorPoint];
 
   // Expected anchor location will be top left when there's no location bar.
   NSWindow* window = browser()->window()->GetNativeWindow();
   NSRect frame = [[window contentView] frame];
-  NSPoint expected = NSMakePoint(
-      NSMinX(frame) + [PermissionBubbleController getFullscreenLeftOffset],
-      NSMaxY(frame));
+  NSPoint expected =
+      NSMakePoint(NSMinX(frame) + kFullscreenLeftOffset, NSMaxY(frame));
   expected = ui::ConvertPointFromWindowToScreen(window, expected);
   EXPECT_NSEQ(expected, anchor);
 }
 
 TEST_F(PermissionBubbleControllerTest,
     AnchorPositionDifferentWithAndWithoutLocationBar) {
   NSPoint withLocationBar;
   {
     base::mac::ScopedObjCClassSwizzler locationSwizzle(
         [PermissionBubbleController class], [MockBubbleYesLocationBar class],
         @selector(hasVisibleLocationBarForBrowser:));
     withLocationBar = [controller_ getExpectedAnchorPoint];
   }
 
   NSPoint withoutLocationBar;
   {
     base::mac::ScopedObjCClassSwizzler locationSwizzle(
         [PermissionBubbleController class], [MockBubbleNoLocationBar class],
         @selector(hasVisibleLocationBarForBrowser:));
     withoutLocationBar = [controller_ getExpectedAnchorPoint];
   }
 
   // The bubble should be in different places depending if the location bar is
   // available or not.
   EXPECT_NSNE(withLocationBar, withoutLocationBar);
 }