Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3434)

Unified Diff: ash/system/network/vpn_list_view.h

Issue 2853143002: Simplify code for VPN entries in system menu (Closed)
Patch Set: Removed unnecessary return Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/system/network/network_state_list_detailed_view.cc ('k') | ash/system/network/vpn_list_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/network/vpn_list_view.h
diff --git a/ash/system/network/vpn_list_view.h b/ash/system/network/vpn_list_view.h
index 23c0009e338a07240bddfeaca38eadd0b055d89b..e59c8d5b584abf4150fa9c1a135504938f227672 100644
--- a/ash/system/network/vpn_list_view.h
+++ b/ash/system/network/vpn_list_view.h
@@ -10,7 +10,6 @@
#include "ash/system/network/network_list_view_base.h"
#include "ash/system/network/vpn_list.h"
-#include "ash/system/tray/view_click_listener.h"
#include "base/macros.h"
#include "chromeos/network/network_state_handler.h"
@@ -40,9 +39,7 @@ class NetworkStateListDetailedView;
// attempt. Clicking on the currently connected or connecting network shows its
// configuration dialog. Clicking on a provider shows the provider's "add
// network" dialog.
-class VPNListView : public NetworkListViewBase,
- public VpnList::Observer,
- public ViewClickListener {
+class VPNListView : public NetworkListViewBase, public VpnList::Observer {
public:
explicit VPNListView(tray::NetworkStateListDetailedView* detailed_view);
~VPNListView() override;
@@ -54,9 +51,6 @@ class VPNListView : public NetworkListViewBase,
// VpnList::Observer:
void OnVPNProvidersChanged() override;
- // ViewClickListener:
- void OnViewClicked(views::View* sender) override;
-
private:
// Adds a network to the list.
void AddNetwork(const chromeos::NetworkState* network);
« no previous file with comments | « ash/system/network/network_state_list_detailed_view.cc ('k') | ash/system/network/vpn_list_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698