Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6449)

Unified Diff: chrome/browser/resources/settings/device_page/power.js

Issue 2853113004: chromeos: Add settings to control power management prefs. (Closed)
Patch Set: re-add some code Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/device_page/power.js
diff --git a/chrome/browser/resources/settings/device_page/power.js b/chrome/browser/resources/settings/device_page/power.js
index a04b51d6109e8879a03f4119c3a4eeeb015b1d10..ec61220b1a9133ddf9298f096b3bfb0dedeaa857 100644
--- a/chrome/browser/resources/settings/device_page/power.js
+++ b/chrome/browser/resources/settings/device_page/power.js
@@ -27,6 +27,12 @@ Polymer({
/** @private {boolean} Whether a low-power (USB) charger is being used. */
lowPowerCharger_: Boolean,
+ /** @private {boolean} Whether the idle behavior is managed. */
+ idleManaged_: Boolean,
+
+ /** @private {boolean} Whether the lid-closed behavior is managed. */
+ lidClosedManaged_: Boolean,
+
/**
* List of available dual-role power sources, if enablePowerSettings is on.
* @private {!Array<!settings.PowerSource>|undefined}
@@ -55,6 +61,46 @@ Polymer({
type: String,
computed: 'computePowerSourceName_(powerSources_, lowPowerCharger_)',
},
+
+ /** @private */
+ idleOptions_: {
+ readOnly: true,
+ type: Array,
+ value: function() {
+ return [
+ {
+ value: settings.IdleBehavior.DISPLAY_OFF_SLEEP,
+ name: loadTimeData.getString('powerIdleDisplayOffSleep'),
+ },
+ {
+ value: settings.IdleBehavior.DISPLAY_OFF_STAY_AWAKE,
+ name: loadTimeData.getString('powerIdleDisplayOffStayAwake'),
+ },
+ {
+ value: settings.IdleBehavior.DISPLAY_ON,
+ name: loadTimeData.getString('powerIdleDisplayOn'),
+ },
+ ];
+ },
+ },
+
+ /** @private */
+ lidClosedOptions_: {
+ readOnly: true,
+ type: Array,
+ value: function() {
+ return [
+ {
+ value: settings.LidClosedBehavior.SLEEP,
+ name: loadTimeData.getString('powerLidClosedSleep'),
+ },
+ {
+ value: settings.LidClosedBehavior.STAY_AWAKE,
+ name: loadTimeData.getString('powerLidClosedStayAwake'),
+ },
+ ];
+ },
+ },
},
/** @override */
@@ -72,6 +118,12 @@ Polymer({
this.addWebUIListener(
'power-sources-changed', this.powerSourcesChanged_.bind(this));
settings.DevicePageBrowserProxyImpl.getInstance().updatePowerStatus();
+
+ this.addWebUIListener(
+ 'power-management-settings-changed',
+ this.powerManagementSettingsChanged_.bind(this));
+ settings.DevicePageBrowserProxyImpl.getInstance()
+ .requestPowerManagementSettings();
},
/**
@@ -113,11 +165,27 @@ Polymer({
return '';
},
+ /** @private */
onPowerSourceChange_: function() {
settings.DevicePageBrowserProxyImpl.getInstance().setPowerSource(
this.$$('#powerSource').value);
},
+ /** @private */
+ onIdleSelectChange_: function() {
+ var behavior = /** @type {settings.IdleBehavior} */
Daniel Erat 2017/05/02 00:58:42 are these casts bogus, or okay? i'm not even sure
michaelpg 2017/05/04 17:36:26 I think this is fine. parseInt makes sense. The ca
Daniel Erat 2017/05/06 00:15:47 Acknowledged.
+ (parseInt(this.$$('#idleSelect').value, 10));
michaelpg 2017/05/04 17:36:26 nit: this.$.idleSelect: https://www.polymer-projec
Daniel Erat 2017/05/06 00:15:47 Done.
+ settings.DevicePageBrowserProxyImpl.getInstance().setIdleBehavior(behavior);
+ },
+
+ /** @private */
+ onLidClosedSelectChange_: function() {
+ var behavior = /** @type {settings.LidClosedBehavior} */
+ (parseInt(this.$$('#lidClosedSelect').value, 10));
michaelpg 2017/05/04 17:36:26 this.$.foo
Daniel Erat 2017/05/06 00:15:47 Done.
+ settings.DevicePageBrowserProxyImpl.getInstance().setLidClosedBehavior(
+ behavior);
+ },
+
/**
* @param {!Array<settings.PowerSource>} sources External power sources.
* @param {string} selectedId The ID of the currently used power source.
@@ -132,6 +200,18 @@ Polymer({
},
/**
+ * @param {!settings.PowerManagementSettings} settings Current power
+ * management settings.
+ * @private
+ */
+ powerManagementSettingsChanged_: function(settings) {
+ this.idleManaged_ = settings.idleManaged;
+ this.lidClosedManaged_ = settings.lidClosedManaged;
+ this.$$('#idleSelect').value = settings.idleBehavior;
+ this.$$('#lidClosedSelect').value = settings.lidClosedBehavior;
michaelpg 2017/05/04 17:36:26 this.$.foo x2
Daniel Erat 2017/05/06 00:15:47 Done.
+ },
+
+ /**
* @param {*} lhs
* @param {*} rhs
* @return {boolean}

Powered by Google App Engine
This is Rietveld 408576698